Skip to content

[process] Establish Java/Kotlin coding standards #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pq opened this issue Apr 23, 2025 · 0 comments
Open

[process] Establish Java/Kotlin coding standards #8098

pq opened this issue Apr 23, 2025 · 0 comments
Assignees
@pq
Labels
P2 task tracking
Milestone
On Deck

Comments

@pq
Copy link
Contributor

pq commented Apr 23, 2025

For Dart contributions, we can point folks to the Dart style guide as a North star. We should establish what we want to do for Java/Kotlin and communicate that in the PR template and Contributing guides as well. (See: #8062).
@pq pq added this to the On Deck milestone Apr 23, 2025
@pq pq self-assigned this Apr 23, 2025
This was referenced Apr 23, 2025
Merged
Merged
Merged
Merged
pq added a commit that referenced this issue Apr 23, 2025
@pq
[CQ] Language migration: use pattern variables (#8104)
529e4cf 
Java 16 introduces [pattern
matching](https://dev.java/learn/pattern-matching/) which allows us to
cleanup some unnecessary casts.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 23, 2025
@pq
[cleanup] Fix Contributing doc TOC and list numbers (#8105)
68f4a11 
Fixes up stale TOC and a step mis-numbering.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced Apr 23, 2025
Merged
Merged
Merged
pq added a commit that referenced this issue Apr 23, 2025
@pq
[PE] make color picker “dark theme” aware (#8109)
255349f 
`java.awt` colors are not dark-theme friendly but `JBColor`s are. As a
bonus we can use the `Gray` constant.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced Apr 24, 2025
Merged
Merged
Merged
jwren pushed a commit that referenced this issue Apr 24, 2025
@pq
[perf] use try-with-resources for auto-closeables (#8111)
afb700d 
Fixes: #8110

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 24, 2025
@pq
[perf] stop static initialization in line marker extension (#8114)
894af53 
![image](https://github.com/user-attachments/assets/bffce434-6527-4501-95d7-129541d8b4b7)

From the inspection description:

> Static initialization is performed once the class is loaded, which may
cause excessive classloading or early initialization of heavy resources.
Since extension point implementations are supposed to be cheap to
create, they must not have static initializers.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 24, 2025
@pq
[fix] bundle properties placeholder format (#8115)
2c97504 
Single-quotes have a special meaning in properties bundles and so we
need to use `"`.


![image](https://github.com/user-attachments/assets/40df2c5a-9675-46c7-a15d-cc7a061344af)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 24, 2025
@pq
[PE] migrate printStackTrace to proper logging (#8116)
fce3759 
Inspection description:

> Reports calls to Throwable.printStackTrace() without arguments.
Such statements are often used for temporary debugging and should be
either removed from the production code or replaced with a more robust
logging facility.

Note that this PR disables the inspection in TEST scopes since
`printStackTrace()` is handy there and "robust" logging in a test
context is often more of a hinderance than help.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced Apr 24, 2025
Merged
Merged
pq added a commit that referenced this issue Apr 24, 2025
@pq
[fix] stop swallowing ProcessCanceledException (#8117)
ac6e7e6 
`ProcessCanceledException`s need to be rethrown so that the IDEA
infrastructure can handle them properly.


![image](https://github.com/user-attachments/assets/722f1b68-e540-48e1-886f-c12e5406c7a7)




---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 24, 2025
@pq
[CQ] remove (dead) empty methods (#8106)
29ce7fb 
More opportunistic tidying.

🧹 Remove unused empty method bodies. (Also a rogue `;`.) 
🧹 Simplify a boolean expression.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue Apr 24, 2025
@pq
[CQ] stop storing property service instance (#8118)
b3a9274 
A bit pedantic but generally good practice and easy to fix. (There's
also no real reason to store the instance.)


![image](https://github.com/user-attachments/assets/529be20b-134e-4c41-8093-7928c676bab7)

Inspection motivation:

> Such services' assignments contribute to global state and make it
impossible to tear down an application and set up another one in tests,
therefore, repeated tests in the same process may fail. The only
exception is an explicit constructor call to store dummy/default
instances.
> The recommended way to avoid storing services is to retrieve a service
locally. Alternatively, one can wrap it in java.util.function.Supplier
(Java, Kotlin) or convert the property to a function (Kotlin).

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue Apr 28, 2025
Merged
1 task
pq added a commit that referenced this issue Apr 28, 2025
@pq
[fix] stale testing.md link (#8120)
1cfc1bb 
The link didn't seem to make the wiki migration:


![image](https://github.com/user-attachments/assets/24306222-276d-4903-aba4-5638aea0023c)


---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 7, 2025
@pq
[CQ] studio-contribs XML cleanup (#8158)
0bed587 
* Suppresses `PluginXmlI18n` where we'll never internationalize.
* Removes a redundant `serviceInterface` declaration.
* (Also: removes an unused import.)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] migrate off deprecated moduleAdded API (#8143)
7400bf3 
The `moduleAdded` callback has been deprecated in favor of a more
general `modulesAdded`:


![image](https://github.com/user-attachments/assets/2ea14067-bb8c-499a-a14d-3d29674c922c)

with source/recommendation:

<img width="849" alt="image"
src="https://github.com/user-attachments/assets/665138b4-9a2e-49a0-aae8-77ed1426c901"
/>

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue May 8, 2025
Merged
1 task
jwren pushed a commit that referenced this issue May 8, 2025
@pq
[CQ] remove dead EditorEventServiceBase (#8163)
2e8f9e8 
Remove a bit more legacy inspector detritus.

Discovered when migrating parent disposables in pursuit of
#8107.


---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced May 8, 2025
Merged
Merged
jwren pushed a commit that referenced this issue May 8, 2025
@pq
[CQ] remove stale FlutterAppManager (#8165)
7bae52b 
This service is unused.

Discovered when migrating parent disposables in pursuit of
#8107.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
jwren pushed a commit that referenced this issue May 8, 2025
@pq
[CQ][perf] remove unused LOG instances (#8164)
d65fed7 
Removes unused `LOG` instances.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced May 8, 2025
Merged
Merged
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] remove stale OutlineLocation (#8166)
6ffdb51 
Another leftover from the removed outline view.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] remove unused AnimatedIcon (#8167)
4c6dedc 
Previously used in the legacy inspector. Now unused.


---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced May 8, 2025
Merged
Merged
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] remove unused FlutterEditorColors (#8168)
70d5613 
Legacy inspector/outline leftovers.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] rename Flutter -> InspectorView (#8169)
1673259 
As discussed, when the inspector was the only view, it made sense to dub
it `FlutterView` but now that's a little general (and suggests an
abstract class of some kind).

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue May 8, 2025
Merged
1 task
pq added a commit that referenced this issue May 8, 2025
@pq
[CQ] remove (legacy) Inspector state-persistence (#8170)
e06c844 
Removes old state persistence from the Inspector (now in devtools).


---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue May 9, 2025
Merged
1 task
pq added a commit that referenced this issue May 9, 2025
@pq
[CQ] InspectorView de-duping and null-awareness (#8173)
18eb068 
Some opportunistic `InspectorView` clean-up.

* a bit of de-duplication and
* some added null-awareness

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
This was referenced May 9, 2025
Merged
Merged
Merged
pq added a commit that referenced this issue May 9, 2025
@pq
[CQ] remove unused ViewListener (#8176)
6d8ec55 
As per a conversation w/ @helin24, this was introduced to persist window
state across project open and close
(#5664) but it no longer
being used.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 9, 2025
@pq
[CQ] remove stale analytics request and bucket objects (#8175)
33890e8 
These bits were introduced in
590d261
and
d4072cf
to support pre-unified analytics and are now unused.



---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
pq added a commit that referenced this issue May 9, 2025
@pq
[CQ] VMServiceManager remove legacy heap/frame monitoring (#8174)
9102f9c 
Performance monitoring is now in devtools so we can stop heap/frame
monitoring (which has been unused since the legacy inspector view went
away).

_There are more threads to pull on here (for example the
`DisplayRefreshRateManager` may be able to go away too but we need to be
sure it doesn't have side-effects that are depended on elsewhere) but
this is a good place to start._

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue May 9, 2025
Merged
1 task
pq added a commit that referenced this issue May 9, 2025
@pq
[PERF] migrate Project parentDisposables to Services (#8178)
f99f8cc 
Using a `Project` as a parent disposable can lead to plugins not being
unloaded correctly leading to memory leaks. This follows the advice
given in the Jetbrains [disposer
docs](https://plugins.jetbrains.com/docs/intellij/disposers.html?from=IncorrectParentDisposable#choosing-a-disposable-parent)
and is (I think) consistent with the Dart plugin (@alexander-doroshko?).

This gets us *most* of the way to fixing
#8107 with an open
question about `AndroidModuleLibraryManager`. (Question posed there 👍 .)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
@pq pq mentioned this issue May 9, 2025
Merged
1 task
pq added a commit that referenced this issue May 9, 2025
@pq
[CQ] remove defunct and unused integration tests (#8179)
d029a3b 
As mentioned in the issue, these are not current, unused and not in the
project source root (so not compiling):


![image](https://github.com/user-attachments/assets/1ac80bf4-914b-4840-aa60-3085fdceb205)


Fixes: #8088



---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
P2 task tracking
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
1 participant
@pq