Skip to content

Commit 9102f9c

Browse files
authored
[CQ] VMServiceManager remove legacy heap/frame monitoring (#8174)
Performance monitoring is now in devtools so we can stop heap/frame monitoring (which has been unused since the legacy inspector view went away). _There are more threads to pull on here (for example the `DisplayRefreshRateManager` may be able to go away too but we need to be sure it doesn't have side-effects that are depended on elsewhere) but this is a good place to start._ --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 33890e8 commit 9102f9c

File tree

4 files changed

+4
-391
lines changed

4 files changed

+4
-391
lines changed

flutter-idea/src/io/flutter/run/daemon/FlutterApp.java

+4-12
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,7 @@
4141
import io.flutter.run.FlutterLaunchMode;
4242
import io.flutter.run.common.RunMode;
4343
import io.flutter.settings.FlutterSettings;
44-
import io.flutter.utils.MostlySilentColoredProcessHandler;
45-
import io.flutter.utils.ProgressHelper;
46-
import io.flutter.utils.StreamSubscription;
47-
import io.flutter.utils.UrlUtils;
48-
import io.flutter.utils.VmServiceListenerAdapter;
49-
import io.flutter.vmService.DisplayRefreshRateManager;
44+
import io.flutter.utils.*;
5045
import io.flutter.vmService.ServiceExtensions;
5146
import io.flutter.vmService.VMServiceManager;
5247
import org.dartlang.vm.service.VmService;
@@ -302,7 +297,9 @@ public ObservatoryConnector getConnector() {
302297
return myConnector;
303298
}
304299

305-
/** @noinspection BooleanMethodIsAlwaysInverted*/
300+
/**
301+
* @noinspection BooleanMethodIsAlwaysInverted
302+
*/
306303
public boolean appSupportsHotReload() {
307304
// Introspect based on registered services.
308305
if (myVMServiceManager != null && myVMServiceManager.hasAnyRegisteredServices()) {
@@ -686,11 +683,6 @@ public VMServiceManager getVMServiceManager() {
686683
return myVMServiceManager;
687684
}
688685

689-
@Nullable
690-
public DisplayRefreshRateManager getDisplayRefreshRateManager() {
691-
return myVMServiceManager != null ? myVMServiceManager.displayRefreshRateManager : null;
692-
}
693-
694686
@NotNull
695687
public Project getProject() {
696688
return myProject;

flutter-idea/src/io/flutter/vmService/FlutterFramesMonitor.java

-147
This file was deleted.

flutter-idea/src/io/flutter/vmService/HeapMonitor.java

-161
This file was deleted.

0 commit comments

Comments
 (0)