Skip to content

Commit 0bed587

Browse files
authored
[CQ] studio-contribs XML cleanup (#8158)
* Suppresses `PluginXmlI18n` where we'll never internationalize. * Removes a redundant `serviceInterface` declaration. * (Also: removes an unused import.) --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent f3e2ec8 commit 0bed587

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

flutter-idea/src/io/flutter/pub/PubRootCache.java

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import com.intellij.openapi.module.Module;
99
import com.intellij.openapi.project.Project;
10-
import com.intellij.openapi.roots.ModuleRootManager;
1110
import com.intellij.openapi.vfs.VirtualFile;
1211
import com.intellij.psi.PsiFile;
1312
import io.flutter.utils.OpenApiUtils;

resources/META-INF/studio-contribs.xml

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,22 @@
1414
<postStartupActivity implementation="io.flutter.FlutterStudioStartupActivity"/>
1515
<projectOpenProcessor implementation="io.flutter.editor.FlutterStudioProjectOpenProcessor" order="after flutter"/>
1616
<library.type implementation="io.flutter.android.AndroidModuleLibraryType"/>
17-
<projectService serviceInterface="io.flutter.android.AndroidModuleLibraryManager"
18-
serviceImplementation="io.flutter.android.AndroidModuleLibraryManager"/>
17+
<projectService serviceImplementation="io.flutter.android.AndroidModuleLibraryManager"/>
1918

2019
</extensions>
2120

2221
<actions>
2322

2423
<!-- Define the 'New Flutter Project' menu item -->
24+
<!--suppress PluginXmlI18n -->
2525
<action id="flutter.NewProject" class="io.flutter.actions.FlutterNewProjectAction"
2626
text="New Flutter Project..."
2727
description="Create a new Flutter project">
2828
<add-to-group group-id="JavaNewProjectOrModuleGroup" anchor="after" relative-to-action="NewProject"/>
2929
</action>
3030

3131
<!-- The icon isn't being used here, but it is set by the action -->
32+
<!--suppress PluginXmlI18n -->
3233
<action id="flutter.NewProject.welcome" class="io.flutter.actions.FlutterNewProjectAction"
3334
text="Create New Flutter Project"
3435
icon="FlutterIcons.Flutter"

resources/META-INF/studio-contribs_template.xml

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,22 @@
1212
<postStartupActivity implementation="io.flutter.FlutterStudioStartupActivity"/>
1313
<projectOpenProcessor implementation="io.flutter.editor.FlutterStudioProjectOpenProcessor" order="after flutter"/>
1414
<library.type implementation="io.flutter.android.AndroidModuleLibraryType"/>
15-
<projectService serviceInterface="io.flutter.android.AndroidModuleLibraryManager"
16-
serviceImplementation="io.flutter.android.AndroidModuleLibraryManager"/>
15+
<projectService serviceImplementation="io.flutter.android.AndroidModuleLibraryManager"/>
1716

1817
</extensions>
1918

2019
<actions>
2120

2221
<!-- Define the 'New Flutter Project' menu item -->
22+
<!--suppress PluginXmlI18n -->
2323
<action id="flutter.NewProject" class="io.flutter.actions.FlutterNewProjectAction"
2424
text="New Flutter Project..."
2525
description="Create a new Flutter project">
2626
<add-to-group group-id="JavaNewProjectOrModuleGroup" anchor="after" relative-to-action="NewProject"/>
2727
</action>
2828

2929
<!-- The icon isn't being used here, but it is set by the action -->
30+
<!--suppress PluginXmlI18n -->
3031
<action id="flutter.NewProject.welcome" class="io.flutter.actions.FlutterNewProjectAction"
3132
text="Create New Flutter Project"
3233
icon="FlutterIcons.Flutter"

0 commit comments

Comments
 (0)