Skip to content

Persist tool window open states during project open/close #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jul 22, 2021

Follow up to #5622

We want to save the state of whether a tool window is open or closed between project open and close (the previous change made it so that tool windows were always closed/not "activated" on project open since the tool windows would all be newly available).

This change can be tested by:

  1. Open a Flutter project
  2. Open one of the Flutter tool windows
  3. Close the project
  4. Reopen the project -> the previously opened Flutter tool window should be opened again once the project is loaded.

@helin24 helin24 merged commit 8133b85 into flutter:master Jul 22, 2021
@helin24 helin24 deleted the persist-toolwindow branch July 22, 2021 20:00
@pq pq mentioned this pull request May 9, 2025
1 task
pq added a commit that referenced this pull request May 9, 2025
As per a conversation w/ @helin24, this was introduced to persist window
state across project open and close
(#5664) but it no longer
being used.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants