-
Notifications
You must be signed in to change notification settings - Fork 2.7k
receiver_creator doesn't work with kafkametrics receiver in 0.123.0 #39313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Something isn't working
help wanted
Extra attention is needed
receiver/kafkametrics
receiver/receivercreator
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for receiver/kafkametrics: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
/assign |
dmitryax
added a commit
that referenced
this issue
Apr 15, 2025
#### Description Fix dynamic start of kafka metrics receiver #### Link to tracking issue Fixes #39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically [this line](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38634/files#diff-ac118f5e10dc8be3556f9c7b192ca2a98161c1289a5a0bc9ddaa812e397acfaaR65). The extra `Unmashall` call seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change in `receiver_creator` also resolves the problem and doesn't have any side effects. #### Testing Follow reproducing steps from the issue
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this issue
Apr 23, 2025
…metry#39395) #### Description Fix dynamic start of kafka metrics receiver #### Link to tracking issue Fixes open-telemetry#39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically [this line](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38634/files#diff-ac118f5e10dc8be3556f9c7b192ca2a98161c1289a5a0bc9ddaa812e397acfaaR65). The extra `Unmashall` call seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change in `receiver_creator` also resolves the problem and doesn't have any side effects. #### Testing Follow reproducing steps from the issue
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this issue
Apr 24, 2025
…metry#39395) #### Description Fix dynamic start of kafka metrics receiver #### Link to tracking issue Fixes open-telemetry#39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically [this line](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38634/files#diff-ac118f5e10dc8be3556f9c7b192ca2a98161c1289a5a0bc9ddaa812e397acfaaR65). The extra `Unmashall` call seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change in `receiver_creator` also resolves the problem and doesn't have any side effects. #### Testing Follow reproducing steps from the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
help wanted
Extra attention is needed
receiver/kafkametrics
receiver/receivercreator
Component(s)
receiver/receivercreator
What happened?
Description
receiver_creator doesn't work with kafkametrics receiver in 0.122.0
Steps to Reproduce
Run a kafka container. https://github.com/apache/kafka/blob/3.7.0/docker/examples/jvm/single-node/plaintext/docker-compose.yml can be used for example
Run collector with receiver_creator and kafkametrics receiver.
Use the following config:
Expected Result
Kafka metrics receiver is automaticaly started and scrapes kafka metrics
Actual Result
Kafka receiver is failing to start with the following logs:
Collector version
0.123.0
Additional context
I investigated to the point that it was introduced by #38634, but haven't gone further yet.
The text was updated successfully, but these errors were encountered: