[receiver_creator] Fix kafkametrics receiver instantiation #39395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 15, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…metry#39395) #### Description Fix dynamic start of kafka metrics receiver #### Link to tracking issue Fixes open-telemetry#39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically [this line](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38634/files#diff-ac118f5e10dc8be3556f9c7b192ca2a98161c1289a5a0bc9ddaa812e397acfaaR65). The extra `Unmashall` call seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change in `receiver_creator` also resolves the problem and doesn't have any side effects. #### Testing Follow reproducing steps from the issue
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…metry#39395) #### Description Fix dynamic start of kafka metrics receiver #### Link to tracking issue Fixes open-telemetry#39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically [this line](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38634/files#diff-ac118f5e10dc8be3556f9c7b192ca2a98161c1289a5a0bc9ddaa812e397acfaaR65). The extra `Unmashall` call seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change in `receiver_creator` also resolves the problem and doesn't have any side effects. #### Testing Follow reproducing steps from the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix dynamic start of kafka metrics receiver
Link to tracking issue
Fixes #39313. The issue is caused by adding the custom unmarshaler to the kafka metrics receiver, specifically this line. The extra
Unmashallcall seems to be redundant. However, it's an establish practice in other receivers. So I don't want to change that yet. The change inreceiver_creatoralso resolves the problem and doesn't have any side effects.Testing
Follow reproducing steps from the issue