receiver/kafkametricsreceiver: use common config and clients #38634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dmitryax,
MovieStoreGuy and
pavolloffay
axw
force-pushed
the
kafkametricsreceiver-embed-clientconfig
branch
3 times, most recently
from
ed179cb to
cc2a7d1
Compare
Use configkafka.ClientConfig, and align with its defaults. This means that client_id now defaults to "otel-collector" instead of "otel-metrics-receiver", which is a breaking change. We also add "metadata.refresh_interval" to ClientConfig, defaulting to 10m, and deprecate "refresh_frequency" from the receiver config. If metadata.refresh_interval is not explicitly set, but refresh_frequency is, then the latter will be used for now.
axw
force-pushed
the
kafkametricsreceiver-embed-clientconfig
branch
from
cc2a7d1 to
f9659c9
Compare
|
Please review conflicts. |
atoulme
approved these changes
Mar 18, 2025
MovieStoreGuy
approved these changes
Mar 20, 2025
|
Fixing conflict now |
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…lemetry#38634) #### Description Remove the duplicated client config from the Config struct, and embed configkafka.ClientConfig. Remove the duplicated (cluster admin) client creation code, and use kafka.NewSaramaClient. This means that client_id now defaults to "otel-collector" instead of "otel-metrics-receiver", which is a breaking change. We also add "metadata.refresh_interval" to ClientConfig, defaulting to 10m, and deprecate "refresh_frequency" from the receiver config. If metadata.refresh_interval is not explicitly set, but refresh_frequency is, then the latter will be used for now. I discovered some of the existing tests are not working correctly while working on this PR, but fixing that will require a much more extensive refactoring effort. I will follow up with another PR once this one is merged. #### Link to tracking issue Part of open-telemetry#38411 #### Testing Updated unit tests. #### Documentation Updated README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the duplicated client config from the Config struct, and embed configkafka.ClientConfig. Remove the duplicated (cluster admin) client creation code, and use kafka.NewSaramaClient.
This means that client_id now defaults to "otel-collector" instead of "otel-metrics-receiver", which is a breaking change.
We also add "metadata.refresh_interval" to ClientConfig, defaulting to 10m, and deprecate "refresh_frequency" from the receiver config. If metadata.refresh_interval is not explicitly set, but refresh_frequency is, then the latter will be used for now.
I discovered some of the existing tests are not working correctly while working on this PR, but fixing that will require a much more extensive refactoring effort. I will follow up with another PR once this one is merged.
Link to tracking issue
Part of #38411
Testing
Updated unit tests.
Documentation
Updated README.