Skip to content

Skip Flutter tool windows for non-Flutter projects (WIP) #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jul 7, 2021

From reading over #4281, it looks like these are the goals:

  • Do not show any of the tool windows (outline, inspector, performance) for non-Flutter projects (defining this as having a Flutter module or being in a bazel workspace)
  • Flutter outline should be available as soon as Flutter project is detected
  • Flutter inspector and performance should be available when an app starts running, although they can also be open when app is not running. Once an app has run these tool windows should remain open
  • Show windows if add to app module is created - Do we also want to remove tool windows if the only Flutter app module is deleted? (Can be done but maybe not worth the trouble)

@google-cla google-cla bot added the cla: yes label Jul 7, 2021
Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after one small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants