Skip to content

Set maximum version of supported DRF and Django #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Aug 18, 2020

Fixes #803

Avoid failling of master if we haven't added support for newly released versions yet.

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Avoid failling of master if we haven't added support
for newly released versions yet.
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files          56       56           
  Lines        3068     3068           
=======================================
  Hits         2990     2990           
  Misses         78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14d8ab...7360967. Read the comment docs.

@sliverc
Copy link
Member Author

sliverc commented Aug 18, 2020

On a side note I was just trying to add Django 3.1 support to DJA. DRF raises quite a few deprecation warnings so we need to wait for a new DRF version anyway before we support Django 3.1

'djangorestframework>=3.10',
'django>=1.11',
'djangorestframework>=3.10,<3.12',
'django>=1.11,<3.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not drop django below 2.2 and add support for 3.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only drop support for Django 1.11 once DRF 3.12 is released as earlier versions still support 1.11. And Django 3.1 can not yet be supported as I have commented above

Copy link

@onurhunce onurhunce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to merge this one since it blocks running the example app :)

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 03f7e7e into django-json-api:master Aug 18, 2020
@sliverc sliverc deleted the highest_supported branch August 18, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

django-polymorphic now does support Django>3.0
4 participants