Skip to content

Set maximum version of supported DRF and Django #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020
+2 −2
Merged

Set maximum version of supported DRF and Django #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Original file line number Diff line number Diff line change
@@ -90,8 +90,8 @@ def get_package_data(package):
],
install_requires=[
'inflection>=0.3.0',
'djangorestframework>=3.10',
'django>=1.11',
'djangorestframework>=3.10,<3.12',
'django>=1.11,<3.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not drop django below 2.2 and add support for 3.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only drop support for Django 1.11 once DRF 3.12 is released as earlier versions still support 1.11. And Django 3.1 can not yet be supported as I have commented above

],
extras_require={
'django-polymorphic': ['django-polymorphic>=2.0'],