Skip to content

Removed upper bounds of Django and DRF #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented May 22, 2023

Description of the Change

In the last couple of new releases of Django and Django REST framework there were no real changes needed in DJA to work with those new versions. With the upper bound, we have currently set in our setup.py, our users need to wait for a new release to use a new Django or DRF version even though no changes are needed in DJA itself.

In #808 we introduced the upper bounds the main reason was to fix a documentation build, so a pipeline issue on our end and not an issue of a user as such.

The problem now is though that our users cannot use Django 4.2 with DJA as we are waiting for DRF to release a version for Django 4.2. (see #1142). As DRF does not have an upper bound though, users can easily use DRF with a new version but not DJA.

As of this, I recommend we remove the upper bound. We only officially support the version mentioned in the changelog/README, but this way we do not stop user using DJA with newer versions, which most likely works just as well.

If there is an actual issue with a new version, we can then temporarily set an upper bound till we have fixed it. In the long run it might also be good to have pinned version for testing, building our documentation etc. (like using poetry), but this is a discussion/work item or another day.

Of course as this change will only be available with the next release this won't directly solve the issue with the Django 4.2 update but with similar situations like this in the future.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

We only set upper bounds in cases a release is actually breaking.
@sliverc sliverc requested a review from n2ygk May 22, 2023 17:58
@n2ygk n2ygk merged commit ac8ffe2 into django-json-api:main May 22, 2023
@sliverc sliverc deleted the remove_upper branch May 22, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants