-
Notifications
You must be signed in to change notification settings - Fork 301
Add support for Django 4.2 #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The tests run pretty quickly regardless, so it should be okay to use the default password hasher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Looks good overall just make sure you do not drop tests for Django 4.1.
Thank you for the review. I have reinstated the Django 4.1 tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It looks good now.
Great, thanks! Do you know when a new release might be cut? This would be blocking any users of the library from upgrading to Django 4.2. |
This kind of depends on when DRF will release a new version supporting Django 4.2. @auvipy Do you have more information when there will be a new DRF release? |
It looks like encode/django-rest-framework#8794 is the relevant issue to track regards a new release. |
I contacted with Tom but he seem to be busy. I hoe we can cut a release in late this month or early next month. |
Thanks for working on this. I'm looking forward to upgrading to django 4.2. What's the release schedule looking like? How long do you think we'd have to wait for this? |
In practice 3.15 did not need any code change for django 4.2 support. But I am still waiting for a response from Tom |
@sliverc, When do you anticipate publishing these changes to PyPI? |
@sliverc We're using DRF with 4.2 in production from the latest release. According to their README it should be already supported. Sorry, if I missed something here and just jumped in without knowning something important. Just wanted to state the obvious (it works with 4.2) 😄 |
DRF 3.15 seems to take longer than anticipated. So I released it now. |
Allows library to be installed with Django 4.2.
Description of the Change
This broadens the range of Django versions this library allows to be installed alongside to include Django 4.2 and any bugfix releases of it.
It also disables the use of the now deprecated
UnsaltedMD5PasswordHasher
hashing algorithm when running tests, as it otherwise would raise deprecation warnings. This will make the tests slightly slower since the default password hashing algorithm uses more resources, but it shouldn't have a big impact all in all as the tests run pretty quickly regardless.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS