Skip to content

Mask thermal paths #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

giuseppe
Copy link
Member

/kind bug

What this PR does / why we need it:

Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default

Fixes #6073

 /proc/interrupts and /sys/devices/system/cpu/*/thermal_throttle are masked by default

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress kind/bug Categorizes issue or PR as related to a bug. labels Mar 20, 2025
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe giuseppe force-pushed the mask-thermal-paths branch from a26646e to f4f8efa Compare March 20, 2025 10:53
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from f4f8efa to 2d3e4dd Compare March 20, 2025 11:41
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Mar 20, 2025
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 2d3e4dd to 0e11a5d Compare March 20, 2025 13:28
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
Closes: containers#6073

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 0e11a5d to 95fb646 Compare March 21, 2025 07:50
@giuseppe giuseppe marked this pull request as ready for review March 21, 2025 07:51
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 95fb646 to cbcdff4 Compare March 21, 2025 07:52
@giuseppe
Copy link
Member Author

@containers/buildah-maintainers ready for review

That is the same configuration used already by Podman.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add / update tests?

LGTM as such.

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

Do we need to add / update tests?

the tests were added to the c/common change

@lsm5
Copy link
Member

lsm5 commented Mar 21, 2025

Do we need to add / update tests?

NVM, looks handled in containers/common#2375 . LGTM.

@flouthoc @nalind PTAL.

@rhatdan
Copy link
Member

rhatdan commented Mar 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bc4d7eb into containers:main Mar 21, 2025
37 checks passed
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 21, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 21, 2025
vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Categorizes issue or PR as related to a bug. lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask Linux thermal interrupt info in /proc and /sys
3 participants