Skip to content

Mask thermal paths #25635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Mar 20, 2025

Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default

vendor the following dependencies:

Closes: #25634

Does this PR introduce a user-facing change?

Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default

@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Mar 20, 2025
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2025
@giuseppe giuseppe marked this pull request as draft March 20, 2025 13:26
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 9d63675 to c281e69 Compare March 20, 2025 13:55
@giuseppe giuseppe added the bloat_approved Approve a PR in which binary file size grows by over 50k label Mar 20, 2025
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from c281e69 to 6305eaf Compare March 20, 2025 15:06
@Honny1
Copy link
Member

Honny1 commented Mar 20, 2025

This PR vendors new feature of Buildah supports of COPY --parents in Containerfile.

@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 6305eaf to 5bbcafa Compare March 21, 2025 13:03
@mheon
Copy link
Member

mheon commented Mar 21, 2025

Should this still be WIP? c/common is merged, no?

vendor the following dependencies:

- containers/common#2375
- containers/buildah#6074

Closes: containers#25634

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 5bbcafa to 260035d Compare March 21, 2025 13:36
@giuseppe
Copy link
Member Author

Should this still be WIP? c/common is merged, no?

no, not a WIP, just waiting for the CI to be green before asking for a review

@giuseppe giuseppe marked this pull request as ready for review March 21, 2025 14:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@giuseppe
Copy link
Member Author

green enough :)

@giuseppe giuseppe changed the title vendor: test new common and buildah Mask thermal paths Mar 21, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7d3ee5a into containers:main Mar 21, 2025
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask Linux thermal interrupt info in /proc and /sys
4 participants