Skip to content

vendor: bump c/common to dbeb17e40c80 #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Mar 6, 2025

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@flouthoc flouthoc marked this pull request as draft March 6, 2025 21:24
@flouthoc flouthoc added No New Tests Allow PR to proceed without adding regression tests and removed do-not-merge/work-in-progress labels Mar 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@TomSweeneyRedHat
Copy link
Member

@flouthoc can this be closed now? I"m assuming you opened this as a test?

@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 20, 2025

@TomSweeneyRedHat I'll rebase it one more time and can point it to actual c/common

@giuseppe
Copy link
Member

#6074 already has a vendoring of c/common

@flouthoc flouthoc marked this pull request as ready for review March 21, 2025 17:28
@flouthoc flouthoc changed the title vendor: c/common test PR c/common@2339 vendor: bump c/common to dbeb17e40c80 Mar 21, 2025
@flouthoc
Copy link
Collaborator Author

Includes changes from containers/common#2339

@flouthoc
Copy link
Collaborator Author

@containers/buildah-maintainers PTAL

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

@mtrmac: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nalind
Copy link
Member

nalind commented Mar 21, 2025

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a7ea2ae into containers:main Mar 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants