Fix for keyboard navigationwhen search-enabled is false #1543

fcaballero · 2016-03-30T21:17:46Z

There are other PR with some fix for #375 but I got some problem trying to rebase, therefor I added those changes in a clean master in order to don't have problems when merged.
The PRs mentioned are #1114 and #1109

…bled is false Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109

wesleycho · 2016-03-30T21:43:30Z

Changes to dist need to be undone. Please run git reset --hard ac0c72f && git push -f

wesleycho · 2016-03-30T21:44:13Z

src/select2/select.tpl.html

-       aria-owns="ui-select-choices-{{ $select.generatedId }}"
-       aria-label="{{ $select.baseTitle }}"
-       aria-activedescendant="ui-select-choices-row-{{ $select.generatedId }}-{{ $select.activeIndex }}"
+             role="combobox"


Fix indentation to 2 spaces, no tabs

Done, please check if it's what you expected...

user378230 · 2016-04-01T14:47:09Z

Can you rebase once more? it should get rid of a bit of noise in the test diff.
Can you fix the white-spacing on the new ng-class attributes
(add space: ng-class="{'ui-select-search-hidden': !$select.searchEnabled}"
You need to squash, when doing so please amend the message according the the commit message style guidelines in CONTRIBUTING.md

ramonjsantiago · 2016-04-14T20:08:26Z

Can the owner of this project resolve the conflicts and merge this pull request #1543 into the angular-ui-select master please?

I really need this one specific fix.

fcaballero · 2016-04-20T10:56:19Z

@wesleycho, @user378230 is everything ok for merging this? or do I miss or mess up something?

user378230 · 2016-04-21T11:33:16Z

@fcaballero I think you merged from master rather than rebased. The only commit should be the one with your changes.

Note also 2 & 3 in my other response:

...

Can you fix the white-spacing on the new ng-class attributes (add space: ng-class="{'ui-select-search-hidden': !$select.searchEnabled}"

You need to squash, when doing so please amend the message according the the commit message style guidelines in CONTRIBUTING.md

- Fix sourcemap generation - Upgrade plugins

- This adds the necessary files (.gitattributes and .editorconfig) to ensure line endings use lf

- Optimize running dynamic width calculations when resizing

Resolves bad changes made in angular-ui#1541 which caused no select.css to be generated as part of the build.

- Converts previous example pages to invidual html partials which are wrapped in standard header and footer as part of a docs build process - Updates all examples to angular v1.5 making use of controllerAs syntax - Standardises the look and feel across examples - Creates dedicated github pages page (docs/index.html) which has links to all examples - Adds an "edit in plunkr" button to launch the example in a plunkr session - Automates the deployment to github pages using travis ci whenever the master branch is built. - General tidy up of README and index docs Closes angular-ui#112

- Prevent accidental removal of a tagged item that subsequently becomes invalid Closes angular-ui#1359

- Ensure at least one item is highlighted before selecting on tab keypress Closes angular-ui#1030

- Explicitly disallow focusing of list, mainly fixes behavior in Firefox Closes angular-ui#898

This reverts commit 06bbd31.

Previously the template was compiled, edited, and then recompiled. This was unnecessary as the changes we unrelated to the scope and so could be made before the link function was run. This change, moves the DOM transformations to the compile function so the directive does not have to be compiled manually. Fixes angular-ui#1000

- Show matches in selectivize template when search is disabled Closes angular-ui#861

- Correctly remove sortable classes from elements on `dragend` Closes angular-ui#902

- Change inputs to `type="search"` - Change to `autocomplete="off"` as per HTML spec Closes angular-ui#991

filenames plugin appeared to be causing header and footer additions to be run twice. Also removes dodgy character at start of header html partial

Do not overflow matched item text out of select block. Closes angular-ui#1337

This reverts commit 9ddc48e.

hide clear button if ui-select is disabled Closes angular-ui#1388 and angular-ui#980

Use triple equals to determine if the selection matches one of the choices. Fixes angular-ui#1328

perf: change test in ctrl.isActive before : ( itemIndex < 0 && ctrl.taggingLabel !== false ) ||( itemIndex < 0 && ctrl.taggingLabel === false) after : itemIndex < 0

use first taggingToken contained in paste data for splitting (previously only first token was used) Closes angular-ui#1566

…bled is false Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109 fix(indentation) use 2 spaces, add white-space

ramonjsantiago · 2016-05-13T14:19:30Z

Can you guys please resolve the conflicts and merge this fix in? It has been hanging out there for a while.

user378230 · 2016-05-13T14:58:26Z

@ramonjsantiago want to have a go yourself? The first post has all the details you need 😃

Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375 Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)

* fix(searchEnabled): maintain keyboard nagivation Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes #1059, fixes #917, fixes #589, fixes #375 Closes #1543, closes #1114, closes #1109 (supersedes all) * fix(selectize): show placeholder when search disabled Previously when searchEnabled was set to false, the placeholder would also be hidden on the selectize theme. This fix sets the search input to disabled rather then hidden when the searchEnabled attribute is set to false. Fixes #1145, fixes #949, fixes #691 * fix(searchEnabled): Prevent searching when disabled Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes #1658

* fix(searchEnabled): maintain keyboard nagivation Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375 Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all) * fix(selectize): show placeholder when search disabled Previously when searchEnabled was set to false, the placeholder would also be hidden on the selectize theme. This fix sets the search input to disabled rather then hidden when the searchEnabled attribute is set to false. Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691 * fix(searchEnabled): Prevent searching when disabled Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes angular-ui#1658

fix(search-enabled) keyboard navigation does not work when search-ena…

ac0c72f

…bled is false Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109

fcaballero mentioned this pull request Mar 30, 2016

Keyboard navigation doesn't work with search-enabled="false" #375

Closed

wesleycho added the needs: review label Mar 30, 2016

wesleycho reviewed Mar 30, 2016
View reviewed changes

fcaballero force-pushed the master branch from e54bc89 to ac0c72f Compare March 31, 2016 09:10

fix(indentation) use 2 spaces, no tabs

5f04993

wesleycho added the needs: squash label Apr 4, 2016

user378230 added the needs: rebasing label Apr 5, 2016

user378230 mentioned this pull request Apr 6, 2016

Fix input box hidding #595

Closed

fix(indentation) use 2 spaces, add white-space

0babb6a

fcaballero force-pushed the master branch from b3de195 to 0babb6a Compare April 25, 2016 17:37

wesleycho and others added 14 commits April 25, 2016 20:06

fix(build): fix sourcemap logic

9ee18ec

- Fix sourcemap generation - Upgrade plugins

chore(bower): update version

a221994

chore: normalize line endings

e740649

- This adds the necessary files (.gitattributes and .editorconfig) to ensure line endings use lf

feat(perf): optimize width resizing

46b719c

- Optimize running dynamic width calculations when resizing

build(css) fix missing dist/select.css

2785b43

Resolves bad changes made in angular-ui#1541 which caused no select.css to be generated as part of the build.

fix(tagging): do not remove selected items when invalid

b5f09cb

- Prevent accidental removal of a tagged item that subsequently becomes invalid Closes angular-ui#1359

fix: ensure highlighted before selecting on tab

6f47a3d

- Ensure at least one item is highlighted before selecting on tab keypress Closes angular-ui#1030

fix(a11y): prevent list from being focusable

158ffa9

- Explicitly disallow focusing of list, mainly fixes behavior in Firefox Closes angular-ui#898

revert: ensure highlighted before selecting on tab

df68b98

This reverts commit 06bbd31.

fix: show select element when search is disabled

ab5ad17

- Show matches in selectivize template when search is disabled Closes angular-ui#861

fix(sortable): remove classes properly

56a7de2

- Correctly remove sortable classes from elements on `dragend` Closes angular-ui#902

fix(autocomplete): change to type="search"

c990206

- Change inputs to `type="search"` - Change to `autocomplete="off"` as per HTML spec Closes angular-ui#991

user378230 and others added 8 commits April 25, 2016 20:07

docs(examples) fix double header/footer wrapping

dff74e3

filenames plugin appeared to be causing header and footer additions to be run twice. Also removes dodgy character at start of header html partial

fix(bootstrap) do not overflow matched item text

aa3b1ff

Do not overflow matched item text out of select block. Closes angular-ui#1337

revert: fix(bootstrap) do not overflow matched item text

a2c1e56

This reverts commit 9ddc48e.

fix(bootstrap): hide clear button if disabled

6d15343

hide clear button if ui-select is disabled Closes angular-ui#1388 and angular-ui#980

fix(uiSelectSingleDirective): strictly compare matching value

ba37f13

Use triple equals to determine if the selection matches one of the choices. Fixes angular-ui#1328

perf: change test in ctrl.isActive

c9fb884

perf: change test in ctrl.isActive before : ( itemIndex < 0 && ctrl.taggingLabel !== false ) ||( itemIndex < 0 && ctrl.taggingLabel === false) after : itemIndex < 0

fix (tagging): try all taggingTokens for splitting on paste

0d63e5d

use first taggingToken contained in paste data for splitting (previously only first token was used) Closes angular-ui#1566

fix(search-enabled) keyboard navigation does not work when search-ena…

ff4818b

…bled is false Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109 fix(indentation) use 2 spaces, add white-space

user378230 mentioned this pull request Jul 10, 2016

Fix numerous issues with select enabled #1717

Merged

aaronroberson closed this in #1717 Aug 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix for keyboard navigationwhen search-enabled is false #1543

Fix for keyboard navigationwhen search-enabled is false #1543

Uh oh!

fcaballero commented Mar 30, 2016

Uh oh!

wesleycho commented Mar 30, 2016

Uh oh!

wesleycho Mar 30, 2016

Uh oh!

fcaballero Mar 31, 2016

Uh oh!

user378230 commented Apr 1, 2016

Uh oh!

ramonjsantiago commented Apr 14, 2016

Uh oh!

fcaballero commented Apr 20, 2016

Uh oh!

user378230 commented Apr 21, 2016

Uh oh!

ramonjsantiago commented May 13, 2016 •

edited

Loading

Uh oh!

user378230 commented May 13, 2016 •

edited

Loading

Uh oh!

Uh oh!

Fix for keyboard navigationwhen search-enabled is false #1543

Fix for keyboard navigationwhen search-enabled is false #1543

Uh oh!

Conversation

fcaballero commented Mar 30, 2016

Uh oh!

wesleycho commented Mar 30, 2016

Uh oh!

wesleycho Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

fcaballero Mar 31, 2016

Choose a reason for hiding this comment

Uh oh!

user378230 commented Apr 1, 2016

Uh oh!

ramonjsantiago commented Apr 14, 2016

Uh oh!

fcaballero commented Apr 20, 2016

Uh oh!

user378230 commented Apr 21, 2016

Uh oh!

ramonjsantiago commented May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

user378230 commented May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ramonjsantiago commented May 13, 2016 •

edited

Loading

user378230 commented May 13, 2016 •

edited

Loading