This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Disable Search demo doesn't disable search. #1658
Labels
Comments
user378230
added a commit
to user378230/ui-select
that referenced
this issue
Jul 11, 2016
Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes angular-ui#1658
kboga
pushed a commit
to kboga/ui-select
that referenced
this issue
Nov 29, 2016
* fix(searchEnabled): maintain keyboard nagivation Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375 Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all) * fix(selectize): show placeholder when search disabled Previously when searchEnabled was set to false, the placeholder would also be hidden on the selectize theme. This fix sets the search input to disabled rather then hidden when the searchEnabled attribute is set to false. Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691 * fix(searchEnabled): Prevent searching when disabled Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes angular-ui#1658
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug description:
Clicking the Disable Search button in the demo does change the label to false, but in all 3 examples the search is still active.
Link to demo:
http://angular-ui.github.io/ui-select/demo-disable-search.html
The text was updated successfully, but these errors were encountered: