Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

arrow key navigation is not working if search-enabled="false" #589

Closed
burib opened this issue Jan 16, 2015 · 15 comments · Fixed by #1717
Closed

arrow key navigation is not working if search-enabled="false" #589

burib opened this issue Jan 16, 2015 · 15 comments · Fixed by #1717
Assignees
@user378230
Labels
type: bug

Comments

@burib
Copy link

burib commented Jan 16, 2015

if search is enabled then you can navigate with arrow keys between the select-items, if search is disabled then arrow key navigation is not working.
@bettercallsteve
Copy link

+1

Looks like keyboard shortcuts (specifically handleDropDownSelection) is being bound to _searchInput.on 'keydown', and disabling the input prevents it from working.

@davideanderson
Copy link

+1

@seinavco
Copy link

+1

Please fix this issue..

@foxx9
Copy link

foxx9 commented Apr 15, 2015

+1

@piebe
Copy link

piebe commented Apr 20, 2015

Problem is not (only) the event listener but the input focus. The input focus is set to searchInput even if search is disabled. Since the input element is not available the focus goes to the body instead and shortcuts and tab order are broken.

So the input focus should be set to another element, but which one...?

@ethagnawl
Copy link

+1. Just spent 20 minutes head-desking over this.

@E-Fil
Copy link

E-Fil commented May 8, 2015

+1

4 similar comments
@brycereynolds
Copy link

+1

@kwantum0
Copy link

+1

@mharmuth
Copy link

mharmuth commented Oct 1, 2015

+1

@danarmstrong
Copy link

+1

bereczdenes added a commit to IPSystems/ui-select that referenced this issue Nov 5, 2015
@bereczdenes
fixing the wollowing two bugs:
004cf6e 
- angular-ui#241
- angular-ui#589
@eXaminator
Copy link

+1

1 similar comment
@unlight
Copy link

unlight commented Jan 15, 2016

+1

messo pushed a commit to IPSystems/ui-select that referenced this issue Feb 15, 2016
@bereczdenes @messo
fixing the wollowing two bugs:
0ee8265 
- angular-ui#241
- angular-ui#589
@timvandijck
Copy link

This is because the input is hided with ngHide. This is not the proper solution but a dirty fix that breaks the keyboard acces to the component.

A better solution for the Select2 theme could be to use the "minimumResultsForSearch" option that Select2 provides.

@brentmiller
Copy link

+1 to fixing this bug.

@user378230 user378230 self-assigned this Jul 10, 2016
user378230 pushed a commit to user378230/ui-select that referenced this issue Jul 10, 2016
@cbryer @user378230
fix(searchEnabled): maintain keyboard nagivation
b5cc902 
Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375
Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)
@user378230 user378230 mentioned this issue Jul 10, 2016
Merged
aaronroberson pushed a commit that referenced this issue Aug 7, 2016
@user378230 @aaronroberson
Fix numerous issues with select enabled (#1717)
be0d301 
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes #1059, fixes #917, fixes #589, fixes #375
Closes #1543, closes #1114, closes #1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes #1145, fixes #949, fixes #691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes #1658
kboga pushed a commit to kboga/ui-select that referenced this issue Nov 29, 2016
@user378230
Fix numerous issues with select enabled (angular-ui#1717)
183c2d6 
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375
Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes angular-ui#1658
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@user378230 user378230

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix numerous issues with select enabled user378230/ui-select