docs(config/node): add boolean to the type
#3050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up for #1317.
|
Preview is ready Built with commit c327877 https://deploy-preview-3050--webpackjsorg-netlify.netlify.com |
anshumanv
reviewed
May 17, 2019
| @@ -16,7 +16,7 @@ This feature is provided by webpack's internal [`NodeStuffPlugin`](https://githu | |||
|
|
|||
| ## `node` | |||
|
|
|||
| `object` | |||
| `boolean | object` | |||
|
|
|||
| This is an object where each property is the name of a Node global or module and each value may be one of the following... | |||
There was a problem hiding this comment.
Please update this too since it can accept bool :)
There was a problem hiding this comment.
The documentation of the false value is at the end:
Since webpack 3.0.0, the
nodeoption may be set tofalseto completely turn off theNodeStuffPluginandNodeSourcePluginplugins.
Would you like me to put that up front instead?
There was a problem hiding this comment.
Ah, missed that one, this looks good! ✨
anshumanv
approved these changes
May 27, 2019
EugeneHlushko
approved these changes
May 27, 2019
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1317.
describe your changes...