docs(config/node): add false for node option
#1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
skipjack
reviewed
Jun 20, 2017
| @@ -17,7 +17,7 @@ These options configure whether to polyfill or mock certain [Node.js globals](ht | |||
| This is an object where each property is the name of a Node global or module and each value may be one of the following... | |||
|
|
|||
| - `true`: Provide a polyfill. | |||
| - `"mock"`: Provide a mock that implements the expected interface but has little or no fuctionality. | |||
| - `"mock"`: Provide a mock that implements the expected interface but has little or no functionality. | |||
There was a problem hiding this comment.
Good catch, that misspelling didn't read too well 😆
skipjack
approved these changes
Jun 20, 2017
foolip
added a commit
to GoogleChromeLabs/confluence
that referenced
this pull request
May 13, 2019
3 tasks
foolip
added a commit
to GoogleChromeLabs/confluence
that referenced
this pull request
May 17, 2019
Dependencies pulled in by `require('crypto')` account for several
hundred kb of vendors.bundle.js.
https://medium.com/walmartlabs/webpack-optimization-a-case-study-92b130334b6c
webpack/webpack.js.org#1317
foolip
added a commit
to GoogleChromeLabs/confluence
that referenced
this pull request
May 17, 2019
Dependencies pulled in by `require('crypto')` account for several
hundred kb of vendors.bundle.js.
https://medium.com/walmartlabs/webpack-optimization-a-case-study-92b130334b6c
webpack/webpack.js.org#1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for webpack/webpack#4995