Skip to content

Rebuild fetch files #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ branches:
- develop
language: node_js
node_js:
- "6"
- '8.9.4'
script:
- bash ./src/scripts/deploy.sh
sudo: required
Expand Down
11 changes: 5 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"url": "https://github.com/webpack/webpack.js.org/issues"
},
"engines": {
"node": ">=6.9"
"node": ">=8.9.4"
},
"scripts": {
"start": "webpack-dev-server --config webpack.dev.js --env.dev",
Expand All @@ -38,8 +38,8 @@
"deploy": "gh-pages -d build"
},
"devDependencies": {
"alex": "^4.1.0",
"async": "^2.5.0",
"@octokit/rest": "^15.2.6",
"alex": "^5.1.0",
"autoprefixer": "^7.2.3",
"babel-core": "^6.26.0",
"babel-eslint": "^7.2.3",
Expand All @@ -62,7 +62,6 @@
"fontgen-loader": "^0.2.1",
"front-matter": "^2.3.0",
"gh-pages": "^1.0.0",
"github": "^10.0.0",
"html-webpack-plugin": "^2.30.1",
"html-webpack-template": "^6.1.0",
"http-server": "^0.10.0",
Expand All @@ -84,11 +83,11 @@
"prism-languages": "^0.3.3",
"prismjs": "^1.9.0",
"raw-loader": "^0.5.1",
"remark-autolink-headings": "^5.0.0",
"redirect-webpack-plugin": "^0.1.1",
"remark-autolink-headings": "^5.0.0",
"remark-loader": "^0.3.0",
"remark-mermaid": "^0.2.0",
"request": "^2.81.0",
"request-promise": "^4.2.2",
"sass-loader": "^6.0.6",
"sitemap-static": "^0.4.2",
"static-site-generator-webpack-plugin": "^3.4.1",
Expand Down
10 changes: 5 additions & 5 deletions src/components/Markdown/Markdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@
margin:1.5em 0 0.25em;
color:getColor(fiord);

&:first-child {
margin-top: 0;
line-height: 1;
}

tt, code { font-size: 90%; color: inherit }
}

h1:first-child {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because, when a README has an h2 heading as the first child, if we remove the margin it gets collapsed with the page title and it looks bad.

margin: 0;
line-height: 1;
}

p, blockquote, table, pre {
margin:1em 0;
}
Expand Down
22 changes: 7 additions & 15 deletions src/scripts/fetch.sh
Original file line number Diff line number Diff line change
@@ -1,25 +1,17 @@
#!/bin/bash
set -e # Exit with nonzero exit code if anything fails

# TODO: Rethink this whole process (maybe use node over shell?)
# XXX: The pages should just be prefixed with an `_` and added to the `./src/content`
# rm -rf ./generated
# mkdir -p ./generated/loaders
# cp -rf ./src/content/loaders/ ./generated/loaders
# mkdir -p ./generated/plugins
# cp -rf ./src/content/plugins/ ./generated/plugins

# Fetch webpack-contrib (and various other) loader repositories
# node ./src/scripts/fetch_package_names.js "webpack-contrib" "-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
# node ./src/scripts/fetch_package_names.js "babel" "babel-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
# node ./src/scripts/fetch_package_names.js "postcss" "postcss-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
# node ./src/scripts/fetch_package_names.js "peerigon" "extract-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
node ./src/utilities/fetchPackageNames.js "webpack-contrib" "-loader" | node ./src/utilities/fetchPackageFiles.js "README.md" "./src/content/loaders"
node ./src/utilities/fetchPackageNames.js "babel" "babel-loader" | node ./src/utilities/fetchPackageFiles.js "README.md" "./src/content/loaders"
node ./src/utilities/fetchPackageNames.js "postcss" "postcss-loader" | node ./src/utilities/fetchPackageFiles.js "README.md" "./src/content/loaders"
node ./src/utilities/fetchPackageNames.js "peerigon" "extract-loader" | node ./src/utilities/fetchPackageFiles.js "README.md" "./src/content/loaders"

# Fetch webpack-contrib (and various other) plugin repositories
# node ./src/scripts/fetch_package_names.js "webpack-contrib" "-webpack-plugin" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/plugins"
node ./src/utilities/fetchPackageNames.js "webpack-contrib" "-webpack-plugin" | node ./src/utilities/fetchPackageFiles.js "README.md" "./src/content/plugins"

# Fetch sponsors and backers from opencollective
node ./src/scripts/fetch_supporters.js
node ./src/utilities/fetchSupporters.js

# Fetch starter kits
# node ./src/scripts/fetch_starter_kits.js
node ./src/utilities/fetchStarterKits.js
144 changes: 0 additions & 144 deletions src/scripts/fetch_package_files.js

This file was deleted.

51 changes: 0 additions & 51 deletions src/scripts/fetch_package_names.js

This file was deleted.

13 changes: 0 additions & 13 deletions src/scripts/fetch_starter_kits.js

This file was deleted.

30 changes: 0 additions & 30 deletions src/scripts/fetch_supporters.js

This file was deleted.

Loading