Rebuild fetch files #2072
Merged
Rebuild fetch files #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we disabled builds on PRS? 🤔 |
montogeek
approved these changes
Apr 23, 2018
| tt, code { font-size: 90%; color: inherit } | ||
| } | ||
|
|
||
| h1:first-child { |
There was a problem hiding this comment.
What is the reason of this change?
There was a problem hiding this comment.
This is because, when a README has an h2 heading as the first child, if we remove the margin it gets collapsed with the page title and it looks bad.
| @@ -0,0 +1,11 @@ | |||
| module.exports = function yamlHeadmatter(fields) { | |||
There was a problem hiding this comment.
This builds the yaml matter for the fetched README files, I didn't add this I just moved it to an specific file so the fetchPackagedFiles script looks cleaner.
|
Squash and merge next time please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all fetch files into the new
rebuildflow.DirectoryTreePlugindetects the files and removes them from computed route name..shone as entry point since moving the API to JavaScript is a little unnecessary, I gave it a try and it's just more spaghetti code.promisify, all fetch flows are now Promise based, no more callback which resulted on tons of lines removed and more readable code.yarn.lockfile to match the rest of the projects in the organizationutilsfolder for better file organization.