Skip to content

Add Glossary Page #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

rouzbeh84
Copy link
Collaborator

@rouzbeh84 rouzbeh84 commented May 16, 2017

Still a WIP...

Building out base for glossary per #970. Definitely needs more items so help would be much appreciated in checking/adding glossary items 👍

@rouzbeh84 rouzbeh84 requested a review from skipjack May 16, 2017 22:06
@skipjack skipjack changed the title initial ingestion of glossary terms. def needs work Add Glossary Page May 17, 2017
@rouzbeh84
Copy link
Collaborator Author

@bebraw would it make sense to port over most of the SurviveJS book glossary terms in here as the 'starting point'?

@skipjack
Copy link
Collaborator

skipjack commented May 19, 2017

@rouzbeh84 just did one pass to clean up grammar and make the formatting more consistent. Please review, and let me know if you think any of the changes I made don't make sense. I think Bundle Splitting can probably be dropped or just point from there to the Code Splitting definition to prevent any confusion (plus I haven't seen the term bundle splitting used much).

@webpack/core-team @webpack/documentation-team @webpack/contributor-team any other thoughts for common terms and definitions that should be added here? I think this is a pretty good start but we could probably sneak a few more in before merging.

@bebraw
Copy link
Contributor

bebraw commented May 19, 2017

@bebraw would it make sense to port over most of the SurviveJS book glossary terms in here as the 'starting point'?

@rouzbeh84 You can expand/rewrite as needed. I wouldn't copy them verbatim (different writing style etc.).

@bebraw
Copy link
Contributor

bebraw commented May 19, 2017

Can you rebase against master? There's something funky going on with the commits.

@rouzbeh84
Copy link
Collaborator Author

@bebraw i dropped the duplicate commit that somehow got wrangled in...

simon04 and others added 5 commits May 19, 2017 10:41
fix the options of ChunkManifestPlugin
)

Update required path for base webpack configuration assigned on 
`CommonConfig` constant.
Rename to code-splitting for consistency, cleanup titles, and make
some other minor formatting/content changes.
@skipjack
Copy link
Collaborator

@rouzbeh84 have you come up with any others yet or are there ones from SurviveJS you plan to port? I'm thinking we leave this open for the rest of this week then try to ship it this weekend. I'll give some thought as to where to add the link to it and add that in soon.

@skipjack skipjack mentioned this pull request May 22, 2017
@rouzbeh84
Copy link
Collaborator Author

I figure I'll start by going through the intro section and adding words that further warrant explanation or will be referenced frequently throughout the docs as I can. I think the high level items are on there for the most part but will dig in each section and see what I can pull out for the glossary.

Also, I would love any help I can get! My explanations are sometimes good and sometimes not so great but I have a busy week this week with a few out of work events as well as work.

rouzbeh84 and others added 2 commits May 23, 2017 20:44
Updating `asset`, `configuration`, and `output` entries and adding `vendor entry point`
@rouzbeh84 rouzbeh84 mentioned this pull request May 24, 2017
@skipjack
Copy link
Collaborator

Closing in favor of #1242...

@skipjack skipjack closed this May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants