fix the options of ChunkManifestPlugin #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have already singed the CLA. |
|
@koalaink yeah we've had a few other people struggle with this as well...
Are you sure you signed with the same "email address used for this commit to your account"? cc @bebraw |
|
I have added the email to my account, while I singed the CLA with another email address.Does it mater? |
simon04
approved these changes
May 19, 2017
There was a problem hiding this comment.
Great, thank you!
Ref: https://github.com/soundcloud/chunk-manifest-webpack-plugin#inlinemanifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set inlineManifest: true cause the default value is false.