Skip to content

Adding commas to requirements/base.txt #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

dougharris
Copy link
Contributor

It was installing click 8.0.0.1a Addresses #649

My testing in a new virtualenv

Original specification of click as in tmuxp's requirements/base.txt

$ cat requirements.txt
click>=7<8

$ pip install -r requirements.txt
Collecting click>=7<8
Using cached click-8.0.0a1-py3-none-any.whl (89 kB)
Installing collected packages: click
Successfully installed click-8.0.0a1

Edit to add the comma

$ cat requirements.txt
click>=7,<8

$ pip install -r requirements.txt
Collecting click<8,>=7
Using cached click-7.1.2-py2.py3-none-any.whl (82 kB)
Installing collected packages: click
Successfully installed click-7.1.2

It was installing click 8.0.0.1a

Addresses tmux-python#649
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #651 (1836f30) into master (c50700b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #651   +/-   ##
=======================================
  Coverage   76.18%   76.18%           
=======================================
  Files           8        8           
  Lines        1142     1142           
  Branches      286      286           
=======================================
  Hits          870      870           
  Misses        196      196           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50700b...1836f30. Read the comment docs.

@tony tony merged commit a4ea2e6 into tmux-python:master Jan 7, 2021
@tony
Copy link
Member

tony commented Jan 7, 2021

@dougharris Thank you!

tony pushed a commit that referenced this pull request Jan 7, 2021
It was installing click 8.0.0.1a

Addresses #649
@tony
Copy link
Member

tony commented Jan 7, 2021

@dougharris Released in 1.6.4 + v1.7.0a4, is it any better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants