Skip to content

Address inconsistent type self.colors returned by Click generating exception in cmd #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joswr1ght
Copy link

Noted in the tmuxp project, libtmux returns an error with the most recent versions of the Click library, where self.colors is a str not an int, leading to the error ValueError: Server.colors must equal 88 or 256. This PR casts the self.colors to an int to accommodate the inconsistency in Click.

CC: @mtrajano

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #304 (b787b5f) into master (6c7c08e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files          16       16           
  Lines        1538     1539    +1     
=======================================
+ Hits         1339     1340    +1     
  Misses        199      199           
Impacted Files Coverage Δ
libtmux/server.py 79.54% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7c08e...b787b5f. Read the comment docs.

@tony
Copy link
Member

tony commented Jun 14, 2021

Thanks

Is there a tmuxp issue to link this to? tmux-python/tmuxp#649, tmux-python/tmuxp#678

@mtrajano @joswr1ght Is this linked to a particular click version? How do we know this won't break systems that already working? Any tests?

@tony
Copy link
Member

tony commented Jun 14, 2021

is this still relevant ATM? (after tmux-python/tmuxp#651?)

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

@mtrajano
Copy link

@tony apologies for the late response, this is not relevant after tmux-python/tmuxp#651 as you mentioned, it can be closed

@tony
Copy link
Member

tony commented Feb 22, 2022

@joswr1ght

Based on what @mtrajano, I assume this PR has been superseded by tmux-python/tmuxp#651

If that is not the case or the issue still persists please let me know

If not feel free to close this. If there's no objection I will close this weekend

@joswr1ght
Copy link
Author

Thank you! Closing.

@joswr1ght joswr1ght closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants