Skip to content

Returns empty string with invalid input #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2019
Merged

Returns empty string with invalid input #5

merged 3 commits into from
Jan 5, 2019

Conversation

Rokt33r
Copy link
Contributor

@Rokt33r Rokt33r commented Jan 4, 2019 •
edited
Loading

@Rokt33r Rokt33r mentioned this pull request Jan 4, 2019
Merged
wooorm
wooorm requested changes Jan 4, 2019
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the docs be updated as well?

@Rokt33r
Copy link
Contributor Author

Rokt33r commented Jan 4, 2019

@wooorm Done!

wooorm
wooorm requested changes Jan 4, 2019
View reviewed changes
@wooorm @Rokt33r
Update readme.md
c40f0dc 
Co-Authored-By: Rokt33r <[email protected]>
@wooorm wooorm merged commit 49d9747 into syntax-tree:master Jan 5, 2019
@Rokt33r Rokt33r deleted the return-empty-string branch January 6, 2019 00:41
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rokt33r @wooorm @ChristianMurphy