Add types #4
Merged
Add types #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Jan 4, 2019
Throwing feels a bit harsh to me, but the empty string is 👍 |
wooorm
approved these changes
Jan 4, 2019
|
Okay, I made a pr for it. #5 |
wooorm
pushed a commit
that referenced
this pull request
Jan 5, 2019
Related to GH-4. Closes GH-5. Reviewed-by: Christian Murphy <[email protected]> Reviewed-by: Titus Wormer <[email protected]>
wooorm
reviewed
Jan 5, 2019
wooorm
added
☂️ area/types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the return type should be union type of
stringandnullbecause typescript assure the argument should beNode,PositionorPoint.Otherwise, we need to check the return value every time if it is
stringor not. That would be horrible.Or maybe it is nice time to change the behavior of the function so we can sure it always returns a
string. (Like returning empty string or throwing an error when it gets an invalid input)