Skip to content

fix: resolve miscellaneous errors in various C examples #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Mar 4, 2024

Resolves #1690.

Description

What is the purpose of this pull request?

This pull request resolves failed C examples in develop.

Related Issues

Does this pull request have any related issues?

Fixes #1690.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title fix: miscellaneous error in various c examples fix: miscellaneous error in various C examples Mar 4, 2024
@Planeshifter Planeshifter changed the title fix: miscellaneous error in various C examples fix: resolve miscellaneous errors in various C examples Mar 4, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. priority: Urgent Issue or feature request must be addressed ASAP. labels Mar 4, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranavchiku Left a couple of comments. Not sure about switching to using a macro over a static const.

@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Mar 4, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@Pranavchiku
Copy link
Member Author

Thanks @kgryte ! Didn't wish to bother you but can you please quickly go through PR #1670?

@kgryte kgryte merged commit d829b75 into stdlib-js:develop Mar 5, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation. priority: Urgent Issue or feature request must be addressed ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: running C examples in develop throws an error
3 participants