Skip to content

feat: add C implementation for math/base/assert/is-odd #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2024
Merged

feat: add C implementation for math/base/assert/is-odd #1670

merged 7 commits into from
Mar 5, 2024

Conversation

Shashankss1205
Copy link
Contributor

@Shashankss1205 Shashankss1205 commented Mar 3, 2024 •
edited by kgryte
Loading

Resolves #1668 .

Description

Added C implementation for @stdlib/math/base/assert/is-odd

Related Issues

Does this pull request have any related issues?

No

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Pranavchiku
Pranavchiku suggested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shashankss1205 for PR! Iterating again we will prioritise quality over number of PRs merged. This PR could have been better with minor observations from your end. I appreciate your efforts, looking forward to more contributions :)

Pranavchiku
Pranavchiku approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge with a quick review. Thank you!

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 3, 2024
@Pranavchiku Pranavchiku mentioned this pull request Mar 3, 2024
Closed
1 task
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/assert/is-odd feat: add C implementation for math/base/assert/is-odd Mar 3, 2024
@Pranavchiku Pranavchiku mentioned this pull request Mar 4, 2024
Closed
3 tasks
@Pranavchiku
Copy link
Member

cc @stdlib-js/reviewers

@kgryte kgryte added the Math Issue or pull request specific to math functionality. label Mar 4, 2024
kgryte
kgryte requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shashankss1205 for working on this. Most comments are related to formatting. You'll benefit from installing EditorConfig, as mentioned in the developer guide.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 4, 2024
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 4, 2024
@Shashankss1205
Copy link
Contributor Author

Thanks @Shashankss1205 for working on this. Most comments are related to formatting. You'll benefit from installing EditorConfig, as mentioned in the developer guide.

Okay I'll follow the above mentioned formatting skills in further code changes and have now installed EditorConfig.

Thank You @Pranavchiku for the rectification commits in this PR.

@Pranavchiku Pranavchiku mentioned this pull request Mar 4, 2024
Closed
3 tasks
@Pranavchiku
Copy link
Member

@kgryte @Planeshifter can you please review this and see if it can be merged?

@Pranavchiku Pranavchiku mentioned this pull request Mar 5, 2024
Merged
1 task
kgryte
kgryte approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Shashankss1205 and @Pranavchiku!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 5, 2024
@kgryte kgryte merged commit f0684da into stdlib-js:develop Mar 5, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
@Shashankss1205 @kgryte @Pranavchiku
feat: add C implementation for math/base/assert/is-odd
33b4f70 
Closes: stdlib-js#1668
PR-URL: 	stdlib-js#1670
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/assert/is-odd
3 participants
@Shashankss1205 @Pranavchiku @kgryte