Skip to content

webworker test fails with recent versions of node #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovasoa opened this issue Nov 22, 2016 · 2 comments
Closed

webworker test fails with recent versions of node #180

lovasoa opened this issue Nov 22, 2016 · 2 comments

Comments

@lovasoa
Copy link
Member

lovasoa commented Nov 22, 2016

This is the prolongation of the discussion started in #179

Webworker-threads already uses BSON for serialization/deserialization. They currently have a bug with typed array, but fixing it seems to just be a matter of updating the version of BSON they use. Their maintainer happens to also be a minister of Taiwan, and says she doesn't have a lot free time to handle this. @dinedal, would you be interested in making her a pull request, and then replace our devDependency from the unmaintained workerjs to worker-threads ?

@lovasoa
Copy link
Member Author

lovasoa commented Nov 22, 2016

Oh, it even looks like node's native parent-child communication supports sending Uint8Arrays. Fixing workerjs would be very easy.

@lovasoa lovasoa changed the title werborker test fails with recent versions of node werbworker test fails with recent versions of node Nov 22, 2016
@lovasoa lovasoa changed the title werbworker test fails with recent versions of node webworker test fails with recent versions of node Nov 22, 2016
@dinedal
Copy link
Collaborator

dinedal commented Nov 29, 2016

Oh, it even looks like node's native parent-child communication supports sending Uint8Arrays. Fixing workerjs would be very easy.

Doesn't seem to be the case, test still fails even once I blast away JSON from workerjs

lovasoa added a commit to kaizhu256/sql.js that referenced this issue Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants