remove coffeescript dependency and use vanilla .js files (#349)

* run shell command:
```sh
# revert individual .coffee files to .js
npm install [email protected]
for LIB in api-data api exports worker
do
    cat "src/$LIB.coffee" | npx coffee --bare --compile --stdio > "src/$LIB.js"
done
# restore package-lock.json
git checkout package-lock.json
```

* update Makefile to use vanilla src/*.js files instead of src/*.coffee

* remove references and dependencies to coffeescript in files:
```
$ git grep -i coffee
.github/workflows/CI.yml:    - name: install coffee
.github/workflows/CI.yml:      run: npm install --global coffeescript@1
.github/workflows/release.yml:      - name: install coffee
.github/workflows/release.yml:        run: npm install --global coffeescript@1
.npmignore:coffee/
package-lock.json:              "coffeescript": {
package-lock.json:                      "resolved": "https://registry.npmjs.org/coffeescript/-/coffeescript-1.12.7.tgz",
package.json:           "coffeescript": "^1.12.7",
```

* remove .coffee files:
        deleted:    src/api-data.coffee
        deleted:    src/api.coffee
        deleted:    src/exports.coffee
        deleted:    src/worker.coffee

* simplify ci-build and vanilla-js cleanup by merging following files into api.js, respectively:
    src/output-pre.js
    src/api.js
    src/exports.js
    src/api-data.js
    src/output-post.js

* rename OUTPUT_API_FILES to SOURCE_API_FILES in Makefile

* add file test/jslint.js and npm-command "npm run test-jslint"
todo - allow test-jslint to fail after we finish refactoring src/api.js (test-jslint currently always pass)

* lint src/api.js - resolve conversation - we need only 1 variable
lint src/api.js - resolve conversation - Object.values()
lint src/api.js - resolve conversation - we can iterate in increasing order
lint src/api.js - resolve conversation - the var could be directly in front of the variables
lint src/api.js - resolve conversation - remove merge-comments
lint src/api.js - unindent case-statement
lint src/api.js - use jslint-style-guide of quoting strings with double-quote instead of single-quote
lint src/api.js - hoist constant vars to top of file
lint src/api.js - rename property SQlite.xxx to var SQLITE_xxx
lint src/api.js - remove var runCompiledCode
lint src/api.js - use 4-space indent

* jslint src/api.js - replace expression "xxx == null" with "isNullOrUndefined(xxx)"
jslint src/api.js - replace expression "void 0" with "undefined"
jslint src/api.js - fix warning "Line is longer than 80 characters."
jslint src/api.js - fix warning "Undeclared xxx."
jslint src/api.js - fix miscellaneous jslint warnings in src/api.js
jslint - allow jslint to print all warnings
jslint - ignore warning subscript_a

* jslint src/api.js - fixed all warnings
jslint - "npm test" will now fail if src/api.js fails jslint-check
jslint src/api.js - fix whitespace warnings

* Add kaizhu256 to the authors

* Add more intermediary files to gitignore

* Create a single "clean" target

* Remove compiled files from the repository

* Keep an empty dist/ folder

* Switch from jslint to eslint

...and fix all warning and errors

* fix a bug I introduced in db.create_function

* Finally fix the webworker tests

Fixes #180

Co-authored-by: Ophir LOJKINE <[email protected]>

Author: kaizhu256

.eslintrc.js

@@ -0,0 +1,37 @@
+module.exports = {
+  env: {
+    browser: true,
+    es6: true,
+    node: true,
+  },
+  extends: [
+    'airbnb-base',
+  ],
+  globals: {
+    Atomics: 'readonly',
+    SharedArrayBuffer: 'readonly',
+  },
+  parserOptions: {
+    ecmaVersion: 5,
+    sourceType: "script",
+  },
+  rules: {
+    "strict": ["error", "function"],
+    "no-cond-assign": ["error", "except-parens"],
+    "no-var": "off",
+    "vars-on-top": "off",
+    "prefer-destructuring": "off",
+    "prefer-spread": "off",
+    "prefer-template": "off",
+    "prefer-arrow-callback": "off",
+    "comma-dangle": "off",
+    "object-shorthand": "off",
+    "no-throw-literal": "off",
+    "no-param-reassign": "off",
+    "no-bitwise": "off",
+    "camelcase": "off",
+    "dot-notation": "off",
+    "indent": ["error", 4],
+    "quotes": ["error", "double"],
+  },
+};

.github/workflows/CI.yml

@@ -10,8 +10,6 @@ jobs:
     - uses: mymindstorm/setup-emsdk@v1
       with:
         version: '1.38.48'
-    - name: install coffee
-      run: npm install --global coffeescript@1
     - uses: actions/cache@v1
       id: cache
       with:

.github/workflows/release.yml

@@ -15,8 +15,6 @@ jobs:
       - uses: mymindstorm/setup-emsdk@v1
         with:
           version: '1.38.48'
-      - name: install coffee
-        run: npm install --global coffeescript@1
       - name: make
         run: make
       - name: Create Release
@@ -37,7 +35,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps 
+          upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps
           asset_path: ./sqljs.zip
           asset_name: sqljs.zip
           asset_content_type: application/zip

.gitignore

@@ -2,6 +2,9 @@ node_modules/
 *~
 
 # Intermediary files:
+cache/
 out/
 sqlite-src/
-cache/
+tmp/
+c/
+emsdk/

.npmignore

@@ -1,6 +1,5 @@
 test/
 c/
-coffee/
 gh-pages/
 node_modules/
 node-debug.log

AUTHORS

@@ -4,3 +4,4 @@ Ophir LOJKINE <[email protected]> (https://github.com/lovasoa)
 @firien
 @dinedal
 @taytay
+@kaizhu256

Makefile

@@ -62,10 +62,10 @@ BITCODE_FILES = out/sqlite3.bc out/extension-functions.bc
 
 OUTPUT_WRAPPER_FILES = src/shell-pre.js src/shell-post.js
 
-OUTPUT_API_FILES = out/api.js
+SOURCE_API_FILES = src/api.js
 
 EMFLAGS_PRE_JS_FILES = \
-	--pre-js out/api.js
+	--pre-js src/api.js
 
 EXPORTED_METHODS_JSON_FILES = src/exported_functions.json src/exported_runtime_methods.json
 
@@ -74,13 +74,13 @@ all: optimized debug worker
 .PHONY: debug
 debug: dist/sql-asm-debug.js dist/sql-wasm-debug.js
 
-dist/sql-asm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
+dist/sql-asm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(SOURCE_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
 	$(EMCC) $(EMFLAGS) $(EMFLAGS_DEBUG) $(EMFLAGS_ASM) $(BITCODE_FILES) $(EMFLAGS_PRE_JS_FILES) -o $@
 	mv $@ out/tmp-raw.js
 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js > $@
 	rm out/tmp-raw.js
 
-dist/sql-wasm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
+dist/sql-wasm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(SOURCE_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
 	$(EMCC) $(EMFLAGS) $(EMFLAGS_DEBUG) $(EMFLAGS_WASM) $(BITCODE_FILES) $(EMFLAGS_PRE_JS_FILES) -o $@
 	mv $@ out/tmp-raw.js
 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js > $@
@@ -89,19 +89,19 @@ dist/sql-wasm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FI
 .PHONY: optimized
 optimized: dist/sql-asm.js dist/sql-wasm.js dist/sql-asm-memory-growth.js
 
-dist/sql-asm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
+dist/sql-asm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(SOURCE_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
 	$(EMCC) $(EMFLAGS) $(EMFLAGS_OPTIMIZED) $(EMFLAGS_ASM) $(BITCODE_FILES) $(EMFLAGS_PRE_JS_FILES) -o $@
 	mv $@ out/tmp-raw.js
 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js > $@
 	rm out/tmp-raw.js
 
-dist/sql-wasm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
+dist/sql-wasm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(SOURCE_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
 	$(EMCC) $(EMFLAGS) $(EMFLAGS_OPTIMIZED) $(EMFLAGS_WASM) $(BITCODE_FILES) $(EMFLAGS_PRE_JS_FILES) -o $@
 	mv $@ out/tmp-raw.js
 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js > $@
 	rm out/tmp-raw.js
 
-dist/sql-asm-memory-growth.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
+dist/sql-asm-memory-growth.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(SOURCE_API_FILES) $(EXPORTED_METHODS_JSON_FILES)
 	$(EMCC) $(EMFLAGS) $(EMFLAGS_OPTIMIZED) $(EMFLAGS_ASM_MEMORY_GROWTH) $(BITCODE_FILES) $(EMFLAGS_PRE_JS_FILES) -o $@
 	mv $@ out/tmp-raw.js
 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js > $@
@@ -111,64 +111,50 @@ dist/sql-asm-memory-growth.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) $(OUTPUT
 .PHONY: worker
 worker: dist/worker.sql-asm.js dist/worker.sql-asm-debug.js dist/worker.sql-wasm.js dist/worker.sql-wasm-debug.js
 
-out/worker.js: src/worker.coffee
-	cat $^ | npx coffee --bare --compile --stdio > $@
-
-dist/worker.sql-asm.js: dist/sql-asm.js out/worker.js
+dist/worker.sql-asm.js: dist/sql-asm.js src/worker.js
 	cat $^ > $@
 
-dist/worker.sql-asm-debug.js: dist/sql-asm-debug.js out/worker.js
+dist/worker.sql-asm-debug.js: dist/sql-asm-debug.js src/worker.js
 	cat $^ > $@
 
-dist/worker.sql-wasm.js: dist/sql-wasm.js out/worker.js
+dist/worker.sql-wasm.js: dist/sql-wasm.js src/worker.js
 	cat $^ > $@
 
-dist/worker.sql-wasm-debug.js: dist/sql-wasm-debug.js out/worker.js
+dist/worker.sql-wasm-debug.js: dist/sql-wasm-debug.js src/worker.js
 	cat $^ > $@
 
 # Building it this way gets us a wrapper that _knows_ it's in worker mode, which is nice.
 # However, since we can't tell emcc that we don't need the wasm generated, and just want the wrapper, we have to pay to have the .wasm generated
 # even though we would have already generated it with our sql-wasm.js target above.
 # This would be made easier if this is implemented: https://github.com/emscripten-core/emscripten/issues/8506
-# dist/worker.sql-wasm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) out/api.js out/worker.js $(EXPORTED_METHODS_JSON_FILES) dist/sql-wasm-debug.wasm
-# 	$(EMCC) $(EMFLAGS) $(EMFLAGS_OPTIMIZED) -s ENVIRONMENT=worker -s $(EMFLAGS_WASM) $(BITCODE_FILES) --pre-js out/api.js -o out/sql-wasm.js
+# dist/worker.sql-wasm.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) src/api.js src/worker.js $(EXPORTED_METHODS_JSON_FILES) dist/sql-wasm-debug.wasm
+# 	$(EMCC) $(EMFLAGS) $(EMFLAGS_OPTIMIZED) -s ENVIRONMENT=worker -s $(EMFLAGS_WASM) $(BITCODE_FILES) --pre-js src/api.js -o out/sql-wasm.js
 # 	mv out/sql-wasm.js out/tmp-raw.js
-# 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js out/worker.js > $@
+# 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js src/worker.js > $@
 # 	#mv out/sql-wasm.wasm dist/sql-wasm.wasm
 # 	rm out/tmp-raw.js
 
-# dist/worker.sql-wasm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) out/api.js out/worker.js $(EXPORTED_METHODS_JSON_FILES) dist/sql-wasm-debug.wasm
-# 	$(EMCC) -s ENVIRONMENT=worker $(EMFLAGS) $(EMFLAGS_DEBUG) -s ENVIRONMENT=worker -s WASM_BINARY_FILE=sql-wasm-foo.debug $(EMFLAGS_WASM) $(BITCODE_FILES) --pre-js out/api.js -o out/sql-wasm-debug.js
+# dist/worker.sql-wasm-debug.js: $(BITCODE_FILES) $(OUTPUT_WRAPPER_FILES) src/api.js src/worker.js $(EXPORTED_METHODS_JSON_FILES) dist/sql-wasm-debug.wasm
+# 	$(EMCC) -s ENVIRONMENT=worker $(EMFLAGS) $(EMFLAGS_DEBUG) -s ENVIRONMENT=worker -s WASM_BINARY_FILE=sql-wasm-foo.debug $(EMFLAGS_WASM) $(BITCODE_FILES) --pre-js src/api.js -o out/sql-wasm-debug.js
 # 	mv out/sql-wasm-debug.js out/tmp-raw.js
-# 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js out/worker.js > $@
+# 	cat src/shell-pre.js out/tmp-raw.js src/shell-post.js src/worker.js > $@
 # 	#mv out/sql-wasm-debug.wasm dist/sql-wasm-debug.wasm
 # 	rm out/tmp-raw.js
 
-out/api.js: src/output-pre.js src/api.coffee src/exports.coffee src/api-data.coffee src/output-post.js
-	mkdir -p out
-	cat src/api.coffee src/exports.coffee src/api-data.coffee | npx coffee --bare --compile --stdio > $@
-	cat src/output-pre.js $@ src/output-post.js > out/api-wrapped.js
-	mv out/api-wrapped.js $@
-
 out/sqlite3.bc: sqlite-src/$(SQLITE_AMALGAMATION)
 	mkdir -p out
 	# Generate llvm bitcode
-	$(EMCC) $(CFLAGS) sqlite-src/$(SQLITE_AMALGAMATION)/sqlite3.c -o $@
+	$(EMCC) $(CFLAGS) -c sqlite-src/$(SQLITE_AMALGAMATION)/sqlite3.c -o $@
 
 out/extension-functions.bc: sqlite-src/$(SQLITE_AMALGAMATION)/$(EXTENSION_FUNCTIONS)
 	mkdir -p out
-	$(EMCC) $(CFLAGS) -s LINKABLE=1 sqlite-src/$(SQLITE_AMALGAMATION)/extension-functions.c -o $@
+	$(EMCC) $(CFLAGS) -s LINKABLE=1 -c sqlite-src/$(SQLITE_AMALGAMATION)/extension-functions.c -o $@
 
 # TODO: This target appears to be unused. If we re-instatate it, we'll need to add more files inside of the JS folder
 # module.tar.gz: test package.json AUTHORS README.md dist/sql-asm.js
 # 	tar --create --gzip $^ > $@
 
 ## cache
-
-.PHONY: clean-cache
-clean-cache:
-	rm -rf cache
-
 cache/$(SQLITE_AMALGAMATION).zip:
 	mkdir -p cache
 	curl -LsSf '$(SQLITE_AMALGAMATION_ZIP_URL)' -o $@
@@ -178,11 +164,6 @@ cache/$(EXTENSION_FUNCTIONS):
 	curl -LsSf '$(EXTENSION_FUNCTIONS_URL)' -o $@
 
 ## sqlite-src
-
-.PHONY: clean-sqlite-src
-clean-sqlite-src:
-	rm -rf sqlite
-
 .PHONY: sqlite-src
 sqlite-src: sqlite-src/$(SQLITE_AMALGAMATION) sqlite-src/$(EXTENSION_FUNCTIONS)
 
@@ -203,10 +184,6 @@ sqlite-src/$(SQLITE_AMALGAMATION)/$(EXTENSION_FUNCTIONS): cache/$(EXTENSION_FUNC
 
 .PHONY: clean
 clean:
-	rm -rf out/* dist/*
-
-.PHONY: clean-all
-clean-all:
 	rm -f out/* dist/* cache/*
-	rm -rf sqlite-src/
+	rm -rf sqlite-src/ c/
 

dist/.gitignore

@@ -0,0 +1,4 @@
+# Ignore everything in this directory
+*
+# Except this file
+!.gitignore