Spec: Opaque type aliases. #17947
Merged
Spec: Opaque type aliases. #17947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
spec-opaque-type-aliases
branch
from
d499013 to
248e014
Compare
bishabosha
reviewed
Jun 20, 2023
bishabosha
reviewed
Jun 20, 2023
bishabosha
reviewed
Jun 20, 2023
Comment on lines
-54
to
-55
| Opaque type aliases cannot be `private` and cannot be overridden in subclasses. | ||
| Opaque type aliases cannot have a context function type as right-hand side. |
There was a problem hiding this comment.
It looks like these restrictions are not mentioned
bishabosha
reviewed
Jun 20, 2023
Comment on lines
-57
to
-69
| ## Type Parameters of Opaque Types | ||
|
|
||
| Opaque type aliases can have a single type parameter list. The following aliases | ||
| are well-formed | ||
| ```scala | ||
| opaque type F[T] = (T, T) | ||
| opaque type G = [T] =>> List[T] | ||
| ``` | ||
| but the following are not: | ||
| ```scala | ||
| opaque type BadF[T] = [U] =>> (T, U) | ||
| opaque type BadG = [T] =>> [U] => (T, U) | ||
| ``` |
There was a problem hiding this comment.
again this restriction is not mentioned
bishabosha
requested changes
Jun 20, 2023
sjrd
force-pushed
the
spec-opaque-type-aliases
branch
from
248e014 to
5b74c9b
Compare
|
Good catch about the missing restrictions! I have added them. |
sjrd
force-pushed
the
spec-opaque-type-aliases
branch
from
5b74c9b to
229738f
Compare
bishabosha
approved these changes
Jun 20, 2023
Kordyjan
added a commit
that referenced
this pull request
Dec 8, 2023
Backports #17947 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]
Based on #17940.