Skip to content

Spec: Adapt basic declarations to the new type system. #17940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

Spec: Adapt basic declarations to the new type system. #17940

merged 1 commit into from
Jun 14, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jun 7, 2023

[skip ci]

@sjrd sjrd mentioned this pull request Jun 9, 2023
Merged
@sjrd
Copy link
Member Author

sjrd commented Jun 14, 2023

@julienrf Can I ask you to review this one? It's starting to be a blocker for my next things to do on the spec.

@sjrd sjrd requested a review from julienrf June 14, 2023 07:51
julienrf
julienrf approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me, thanks!

@sjrd sjrd force-pushed the spec-declarations branch from 0659a8f to 9ec07a2 Compare June 14, 2023 09:06
@sjrd sjrd requested a review from julienrf June 14, 2023 09:08
@sjrd
Copy link
Member Author

sjrd commented Jun 14, 2023

Thanks for the review :)

@sjrd sjrd merged commit 89de881 into scala:main Jun 14, 2023
@sjrd sjrd deleted the spec-declarations branch June 14, 2023 09:34
sjrd added a commit that referenced this pull request Jun 20, 2023
@sjrd
Spec: Opaque type aliases. (#17947)
47ec229 
[skip ci]

Based on #17940.
@Kordyjan Kordyjan mentioned this pull request Nov 17, 2023
Merged
Kordyjan added a commit that referenced this pull request Nov 21, 2023
@Kordyjan
Backport "Spec: Adapt basic declarations to the new type system." to …
a650627 
…LTS (#18988)

Backports #17940 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan mentioned this pull request Nov 23, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "Spec: Rewrite the type system fundamentals." to LTS (#19034)
a04b90f 
Backports #17447 to the LTS branch.

This PR was initially erroneously skipped.
It also includes changes form #17940.

[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees

@julienrf julienrf

Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sjrd @julienrf @Kordyjan