Add reflect newMethodOverride and newValOverride #15041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-15035
branch
from
c4bef92 to
9fbb3b4
Compare
nicolasstucki
force-pushed
the
fix-15035
branch
3 times, most recently
from
0886295 to
bbebc00
Compare
smarter
requested changes
Dec 5, 2022
| * @param overridden The symbol being overridden | ||
| */ | ||
| @experimental | ||
| def newMethodOverride(parent: Symbol, overridden: Symbol): Symbol |
There was a problem hiding this comment.
This API isn't flexible enough to handle situations where you need to override two methods at once. For example:
trait X; trait Y
trait A { def foo: X }
trait B { def foo: Y }
class C extends A with B {
// ...
}In C, if I try to override only A#foo or only B#foo, I will get a type error, I'm forced to override both at once.
smarter
reviewed
Dec 5, 2022
| @@ -3687,6 +3696,15 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching => | |||
| */ | |||
| def newVal(parent: Symbol, name: String, tpe: TypeRepr, flags: Flags, privateWithin: Symbol): Symbol | |||
|
|
|||
| /** Generates a new `val` or `lazy val` symbol that overrides another definition. | |||
There was a problem hiding this comment.
No. This design does not compose well. It might be better to have an API to compute the methodic type of the override signature and use the other newVal overloads to create the symbol with the appropriate flags. This would require the introduction of .info.
nicolasstucki
force-pushed
the
fix-15035
branch
from
bbebc00 to
2489fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15035