Add reflect Symbol.info and TypeRepr.asSeenFrom #15024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found this missing method because of this use case #11685 (comment). |
smarter
requested changes
Apr 25, 2022
There was a problem hiding this comment.
- I think
tpeas a name is too close to typeRef/termRef while doing something different. I'm not a fan ofinfobut at least it's established jargon in Scala. - If we add this we should also add
asSeenFromsince most of the time we're interested in the info as seen from a specific prefix and forgetting to use the correct prefix is a common source of bugs. This was also requested recently: "asSeenFrom" in Scala 3 #14957 - For the purpose of overriding we should provide some convenience method (
Symbol.newMethodOverride?) which given a method symbol in a parent takes care of generating a new symbol with the correct info and flags to override it.
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
add-refelct-symbol-tpe
branch
2 times, most recently
from
4e01f55 to
838a454
Compare
smarter
requested changes
Apr 26, 2022
| val parents = List(TypeTree.of[Object], TypeTree.of[T]) | ||
|
|
||
| def decls(cls: Symbol): List[Symbol] = methods.map { method => | ||
| Symbol.newMethod(cls, method.name, method.info, flags = Flags.EmptyFlags /*TODO: method.flags */, privateWithin = method.privateWithin.fold(Symbol.noSymbol)(_.typeSymbol)) |
There was a problem hiding this comment.
I see you opened #15035 but it's classified as an enhancement when I think it should be required to stabilize Symbol.newClass
There was a problem hiding this comment.
I'm working on that one now. I intend to open a separate PR for that one as it is not directly related with the info.
|
Very keen to see this get into the mainline! |
nicolasstucki
force-pushed
the
add-refelct-symbol-tpe
branch
from
838a454 to
d48b91e
Compare
24 tasks
nicolasstucki
force-pushed
the
add-refelct-symbol-tpe
branch
from
d48b91e to
98e10d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.