Skip to content

Bring back some disabled ScalaTest tests #14767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

nicolasstucki
Copy link
Contributor

We only need to disable the tests that involve getMessage on
a fact that was produced by explicitly compiling a String.

Closes #14712

We only need to disable the tests that involve getMessage on
a fact that was produced by explicitly compiling a String.

Closes scala#14712
@nicolasstucki nicolasstucki marked this pull request as ready for review March 24, 2022 12:12
@nicolasstucki nicolasstucki requested a review from odersky March 24, 2022 14:01
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could finetune this so that only tests that check error messages are disabled. But that can come later.

@nicolasstucki nicolasstucki merged commit d26a860 into scala:main Mar 24, 2022
@nicolasstucki nicolasstucki deleted the fix-14712 branch March 24, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back some disabled ScalaTest tests
2 participants