Bring back some disabled ScalaTest tests #14712
Assignees
Labels
Comments
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this issue
Mar 24, 2022
We only need to disable the tests that involve getMessage on a fact that was produced by explicitly compiling a String. Closes scala#14712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiler version
3.1.3-RC2
Description
I also had to disable in #14695 two scalatest tests:
ExpectationsSpecandDirectExpectationsSpec. These were test suites containing tests that checked the precise error message output of the dotty compiler. IMO such tests should never be in a regression test suite for the community build, since they essentially lock in current behavior. We do want tests about error messages of course, but these should be compiler tests that can easily be changed if the compiler's error diagnostics improve.Not knowing scalatest. I was not able to figure out from the diagnostics which particular tests broke in the two suites, so I disabled them wholesale. It would be good to bring back those tests in
ExpectationsSpecandDirectExpectationsSpecof scalatest that do not depend on specific error diagnostics of dotc.The text was updated successfully, but these errors were encountered: