Support scala 3 #446

russwyte · 2021-02-26T19:54:24Z

Add support for Scala 3.0.0-RC1 in anticipation of final release of Scala 3.0.0

src/main/scala/org/scalajs/dom/experimental/sharedworkers/SharedWorker.scala

vhiairrassary · 2021-03-02T17:57:15Z

@russwyte What do you think about adding the newly supported version in CI pipeline?

russwyte · 2021-03-02T18:07:05Z

Travis CI seems super slow for this. It may be time to consider moving to github actions.

.github/workflows/ci.yml

build.sbt

sjrd · 2021-03-03T13:53:46Z

src/main/scala/org/scalajs/dom/experimental/URL.scala

-class URL(url: String, base: String = js.native) extends js.Object {
+class URL(url: String, base: String) extends js.Object {
+  def this(url: String) = this(url, js.native)


Why is this necessary? If the original code is not accepted by Scala 3, please report an issue to the dotty repo, because that's a bug.

Yeah the original would not compile in 3.0.0-RC1 - I will report.

Created:
scala/scala3#11592

build.sbt

russwyte · 2021-03-03T16:23:01Z

@sjrd I am a bit stumped as to why this won't compile for 2.10.7/0.6.x:

[info] set current project to Scala.js DOM (in build file:/home/runner/work/scala-js-dom/scala-js-dom/)
[info] Setting Scala version to 2.10.7 on 2 projects.
[info] Excluded 1 projects, run ++ 2.10.7 -v for more details.
[info] Reapplying settings...
[info] set current project to Scala.js DOM (in build file:/home/runner/work/scala-js-dom/scala-js-dom/)
[info] compiling 53 Scala sources to /home/runner/work/scala-js-dom/scala-js-dom/target/scala-2.10/classes ...
[error] /home/runner/work/scala-js-dom/scala-js-dom/src/main/scala/org/scalajs/dom/experimental/beacon/package.scala:44:70: js.native may only be used as stub implementation in facade types
[error]     def sendBeacon(url: String, data: BodyInit = null): Boolean = js.native
...

sjrd · 2021-03-03T16:27:59Z

It does seem weird. Can you reproduce the issue locally?

russwyte · 2021-03-03T16:53:18Z

It does seem weird. Can you reproduce the issue locally?

yes - running:

 SCALAJS_VERSION="0.6.28" sbt "++2.10.7" example/compile

fails.

russwyte · 2021-03-03T17:56:46Z

@sjrd The compiler error seems to be an issue with order of build tasks and incremental compiling.

I added a clean to the problematic step example/compile and it cleared up the CI build.

russwyte · 2021-04-01T21:41:32Z

@sjrd It looks like DottyDoc does not like some of our overloaded constructors. That has me stuck.

raquo · 2021-04-25T00:54:35Z

Does anyone know if the blockers have been addressed in RC3?

russwyte · 2021-04-25T12:28:02Z

Does anyone know if the blockers have been addressed in RC3?

I tried RC3 a few days ago and unfortunately the DottyDoc issue still persists. Everything else is working.

sjrd · 2021-04-25T14:38:35Z

It would be nice if someone could minimize and report the issue to the dotty repo.

russwyte · 2021-04-25T15:56:37Z

It would be nice if someone could minimize and report the issue to the dotty repo.

scala/scala3#12215

russwyte · 2021-06-03T14:45:19Z

@sjrd that last commit got scaladocs working for Scala 3. Please let me know if more is needed.

armanbilge · 2021-07-01T04:44:39Z

@russwyte @sjrd What will it take to get this merged? Happy to pitch in a hand :) we'd love this over at http4s/http4s#4938

armanbilge · 2021-07-06T18:14:11Z

@sjrd @gzm0 just a polite bump. I understand if you are busy to review, but at the very least could you kindly approve the workflow, so we can see how this PR stands against CI?

sjrd · 2021-07-06T20:08:05Z

There's nothing that I can approve. It just says "Workflow completed with no jobs." 🤔😕

armanbilge · 2021-07-06T20:36:48Z

@sjrd thanks for your attention ... that's strange. I tried re-opening in #449, can you approve there?

sjrd · 2021-07-06T22:29:20Z

Done

armanbilge · 2021-07-06T22:44:28Z

Thank you very much! ~~I'll continue working on the PR there.~~

armanbilge · 2021-07-06T23:06:54Z

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
        include:
          - scalaversion: "2.10.7"
            scalajsversion: "0.6.x"
-          - scalaversion: "3.0.1-RC1"
+          - scalaversion: "3.0.1-RC2"


Why bump to a RC? let's first get this released for 3.0.0 😅

Already tried 3.0.0 (earlier) and it didn't work because of sbt and scaladoc/dottydoc borkage with scalajs. But if it can work now (maybe SBT fix?) - that's great! 👍

3.0.1-RC1 and on will work right now.

I see! Frustrating. Btw thanks for picking this up again!

PS if you make a tiny PR to this repo (e.g. fix a typo) maybe @sjrd can merge it quick and then you'll be whitelisted for CI.

I don't mind doing a PR like that, but what is strange is that until a few commits ago CI was working fine.

GH changed their policy recently, maybe while you were working on this. It makes contributing more difficult IMO.

armanbilge · 2021-07-09T13:26:58Z

@russwyte @sjrd Scala 3.0.1 was just released and CI is green. So, what will it take to merge? :)

armanbilge · 2021-07-14T06:00:02Z

@sjrd another polite bump. At least let's run the workflow, please?

Myp · 2021-07-14T07:54:32Z

@sjrd I agree with @armanbilge :) let's rock please!

sjrd

Thanks for the continued efforts.

I have some comments below. In addition, could you squash/rebase everything in 3 commits with appropriate commit messages:

Upgrade sbt and change the syntax
Upgrade Scala.js to 1.5.0
Add the support for Scala 3, and all the other changes.

sjrd · 2021-07-14T07:42:19Z

.github/workflows/ci.yml

-        run: sbt "++${{ matrix.scalaversion }}" package
+        run: sbt "++${{ matrix.scalaversion }} package"
      - name: Test generate documentation
        run: sbt "++${{ matrix.scalaversion }}" doc
      - name: Build examples
-        run: sbt "++${{ matrix.scalaversion }}" example/compile
+        run: sbt "++${{ matrix.scalaversion }} clean;example/compile"


Those changes shouldn't be necessary.

sjrd · 2021-07-14T07:43:27Z

build.sbt

-  (resources in Compile) += (fullOptJS in (example, Compile)).value.data
+  (Compile / resources) += (example / Compile / fullOptJS).value.data,


When rebasing, can you isolate those changes of build syntax in a first commit, together with the upgrade of sbt, please?

sjrd · 2021-07-14T07:44:10Z

src/main/scala/org/scalajs/dom/experimental/webrtc/WebRTC.scala

-import scala.scalajs.js.typedarray.{ArrayBufferView, ArrayBuffer}
-import scala.scalajs.js.|
-
+import scala.scalajs.js.typedarray.{ArrayBuffer, ArrayBufferView}
+import scala.scalajs.js.{undefined, |}


Spurious changes that should be reverted.

sjrd · 2021-07-14T07:44:44Z

src/main/scala/org/scalajs/dom/experimental/webrtc/WebRTC.scala

-  def this(init: RTCDataChannelEventInit) = this("datachannel", init)
+  def this(init: js.UndefOr[RTCDataChannelEventInit]) =
+    this(typeArg = "datachannel", init = init)


Does this change have anything to do with the support for Scala 3?

sjrd · 2021-07-14T07:45:20Z

src/main/scala/org/scalajs/dom/ext/package.scala

 import scala.language.implicitConversions
-


Please keep this empty line. We always keep import scala.language.* separate from the others.

sjrd · 2021-07-14T07:46:51Z

src/main/scala/org/scalajs/dom/raw/lib.scala

-class KeyboardEvent(typeArg: String, init: js.UndefOr[KeyboardEventInit])
+class KeyboardEvent(typeArg: String,
+    init: js.UndefOr[KeyboardEventInit] = js.native)
    extends UIEvent(typeArg, init) with ModifierKeyEvent {

-  def this(typeArg: String) = this(typeArg, js.native)
+//  def this(typeArg: String) = this(typeArg, js.native)


Do these changes have anything to do with Scala 3 support?

armanbilge · 2021-07-14T11:54:48Z

@sjrd In #450 I rebased and fixed according to your comments. I hope that adding @russwyte to the rebased commits as a co-author is consistent with your coding style; please advise.

sjrd · 2021-07-14T13:54:39Z

Superseded by #450.

russwyte added 2 commits February 26, 2021 13:52

suport scala 3.0.0-RC1

344bb13

scalafm

ad63fe5

DanHodges approved these changes Feb 26, 2021

View reviewed changes

russwyte mentioned this pull request Feb 26, 2021

WIP: initial attempt to update to scala 3.0.0-M3 #438

Closed

taig reviewed Mar 1, 2021

View reviewed changes

src/main/scala/org/scalajs/dom/experimental/sharedworkers/SharedWorker.scala Outdated Show resolved Hide resolved

russwyte added 2 commits March 2, 2021 10:42

override constructors where appropriate

5910767

scalafmt

5079836

russwyte added 2 commits March 2, 2021 12:02

update CI pipeline

d8abc03

update CI pipeline

4397c7b

russwyte added 2 commits March 2, 2021 13:24

exclude 2.13.5 from 0.6.28 build

bf33bf1

also need to exlude scala 3 from 0.6.28

f561225

russwyte requested a review from sjrd March 2, 2021 20:21

russwyte added 2 commits March 3, 2021 07:38

fix conflicts

0425741

update CI to inlude all supported versions

9606d60

sjrd reviewed Mar 3, 2021

View reviewed changes

russwyte added 4 commits March 3, 2021 07:58

don't use 2.13.5

28eeb7d

remove jcenter

3c0e714

put back jcenter repo

d15c21b

use include instead of exclude

7d70b3d

russwyte mentioned this pull request Mar 3, 2021

Compiler rejects native default constructor parameters when compiling Scala.js native classes scala/scala3#11592

Closed

russwyte added 3 commits March 3, 2021 11:00

clean before package

ea04026

need to quute

b8c4311

clean before compiling example

47cc047

scalafmt

5176b44

scala 3.0.0 FTW

f77e53a

russwyte changed the title ~~Support scala 3.0.0-RC2~~ Support scala 3 May 13, 2021

get scaladocs for scala 3 working

ed3ad20

armanbilge mentioned this pull request Jul 1, 2021

Cross-build for Scala 3 #448

Closed

armanbilge mentioned this pull request Jul 2, 2021

Cross-build http4s for Scala.js http4s/http4s#4938

Merged

armanbilge mentioned this pull request Jul 6, 2021

Support scala 3 #449

Closed

scalafmt and bump scala 3 version

0432c8f

armanbilge reviewed Jul 6, 2021

View reviewed changes

update scala to release version 3.0.1

cf5e4e7

sjrd requested changes Jul 14, 2021

View reviewed changes

armanbilge mentioned this pull request Jul 14, 2021

Support Scala 3 #450

Merged

sjrd closed this Jul 14, 2021

		(resources in Compile) += (fullOptJS in (example, Compile)).value.data
		(Compile / resources) += (example / Compile / fullOptJS).value.data,

Support scala 3 #446

Support scala 3 #446

Conversation

russwyte commented Feb 26, 2021

vhiairrassary commented Mar 2, 2021

russwyte commented Mar 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

russwyte commented Mar 3, 2021

sjrd commented Mar 3, 2021

russwyte commented Mar 3, 2021

russwyte commented Mar 3, 2021

russwyte commented Apr 1, 2021

raquo commented Apr 25, 2021

russwyte commented Apr 25, 2021

sjrd commented Apr 25, 2021

russwyte commented Apr 25, 2021

russwyte commented Jun 3, 2021

armanbilge commented Jul 1, 2021

armanbilge commented Jul 6, 2021

sjrd commented Jul 6, 2021

armanbilge commented Jul 6, 2021

sjrd commented Jul 6, 2021

armanbilge commented Jul 6, 2021 • edited Loading

Choose a reason for hiding this comment

russwyte Jul 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armanbilge commented Jul 9, 2021

armanbilge commented Jul 14, 2021

Myp commented Jul 14, 2021

sjrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armanbilge commented Jul 14, 2021 • edited Loading

sjrd commented Jul 14, 2021

armanbilge commented Jul 6, 2021 •

edited

Loading

russwyte Jul 6, 2021 •

edited

Loading

armanbilge commented Jul 14, 2021 •

edited

Loading