Skip to content

WIP: initial attempt to update to scala 3.0.0-M3 #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scalavision
Copy link

@scalavision scalavision commented Jan 10, 2021

This is an attempt to upgrade the lib to scala 3.0.0-M3, unfortunately the compiler crash at building a typed array, at this line

https://github.com/scala-js/scala-js-dom/compare/master...scalavision:upgrade-scala3-M3?expand=1#diff-314a459d5f91479dc5debdf12f163c51278abfcee6b3503ad31dea16d07a4f61R216

I will file a bug in either scala-js or dotty (depending on where it fits best) and point to this branch. I get this compiler output:

[error] -- Error: /../scala-js-dom/src/main/scala/org/scalajs/dom/ext/Extensions.scala:219:6 
[error] 219 |      tempBuffer.typedArray()
[error]     |      ^
[error]     |Recursion limit exceeded.
[error]     |Maybe there is an illegal cyclic reference?
[error]     |If that's not the case, you could also try to increase the stacksize using the -Xss JVM option.
[error]     |A recurring operation is (inner to outer):

[error]     |  subtype scala.scalajs.js.typedarray.TypedArray[?, 
[error]     |  LazyRef(
[error]     |    scala.scalajs.js.typedarray.TypedArrayBufferOps[?
[error]     |       <: scala.scalajs.js.typedarray.TypedArray[?, ?]
[error]     |    ]#TypedArrayType
[error]     |  )
[error]     |] <:< scala.scalajs.js.typedarray.TypedArray[?, ?]
[error]     |  subtype Nothing <:< LazyRef(
[error]     |  scala.scalajs.js.typedarray.TypedArrayBufferOps[?
[error]     |     <: scala.scalajs.js.typedarray.TypedArray[?, ?]
[error]     |  ]#TypedArrayType
[error]     |)
[error]     |  subtype scala.scalajs.js.typedarray.TypedArray[?, 
[error]     |  LazyRef(
[error]     |    scala.scalajs.js.typedarray.TypedArrayBufferOps[?
[error]     |       <: scala.scalajs.js.typedarray.TypedArray[?, ?]
[error]     |    ]#TypedArrayType
[error]     |  )
[error]     |]

Increasing the stack doesn't help.

@sjrd
Copy link
Member

sjrd commented Jan 10, 2021

It's a compiler crash, so it's necessarily an issue in dotty. And here apparently it's not even related to Scala.js.

@scalavision
Copy link
Author

Thanks , I'll report an issue in dotty then :-)

@scalavision
Copy link
Author

@russwyte
Copy link
Contributor

I have a similar PR - and it seems to be green.

#446

@scalavision
Copy link
Author

Great! Then I'll close mine, thank you very much :-) There was a bug fixed some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants