Skip to content

Fix #280: Allow nodeValue to set value. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

Fix #280: Allow nodeValue to set value. #364

merged 1 commit into from
May 14, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented May 13, 2019

Closes #280

@sjrd sjrd changed the title Allow nodeValue to set value. Fix #280: Allow nodeValue to set value. May 14, 2019
@sjrd sjrd merged commit 7039430 into scala-js:master May 14, 2019
@exoego exoego deleted the nodeValue branch May 14, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.nodeValue should be var
2 participants
@exoego @sjrd