Skip to content

Node.nodeValue should be var #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ochrons opened this issue Apr 17, 2017 · 1 comment · Fixed by #364
Closed

Node.nodeValue should be var #280

ochrons opened this issue Apr 17, 2017 · 1 comment · Fixed by #364

Comments

@ochrons
Copy link

ochrons commented Apr 17, 2017

Currently nodeValue is a def but it should be var to allow setting a new nodeValue.

From https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeValue

The Node.nodeValue property returns or sets the value of the current node.

For Text node a work-around is to use the data property.
@exoego
Copy link
Contributor

exoego commented May 13, 2019

It seems that nodeValue supposed to raise Exception on setting in DOM Level 2.
In DOM Level 4, it won't.

@exoego exoego mentioned this issue May 13, 2019
Merged
@sjrd sjrd closed this as completed in #364 May 14, 2019
sjrd pushed a commit that referenced this issue May 14, 2019
@sjrd
Fix #280: Allow nodeValue to set value. (#364)
7039430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #280: Allow nodeValue to set value. exoego/scala-js-dom
2 participants
@exoego @ochrons