Skip to content

Make install button easier #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2020
Merged

Make install button easier #1004

merged 3 commits into from
Feb 10, 2020

Conversation

Zexbe
Copy link
Contributor

@Zexbe Zexbe commented Feb 3, 2020 •
edited
Loading

Fixes: #969
Possibly Fixes: #954
Possibly Fixes: #733

Before

Before

After

mini
small
larger

@Zexbe Zexbe changed the title Make install button easier [WIP] Make install button easier Feb 3, 2020
@Zexbe Zexbe requested a review from pietroalbini February 3, 2020 08:11
@pietroalbini pietroalbini removed their request for review February 3, 2020 08:59
@pietroalbini pietroalbini self-assigned this Feb 3, 2020
@pietroalbini
Copy link
Member

Thanks for the PR!

As far as I'm aware this would be the only page with an 80% width paragraph, which is not consistent with the rest of the site. An alternative approach would be to keep the 100% width for the paragraph while having two buttons instead of one in the row below:

This would also provide yet another band-aid for rust-lang/rustup#2179 (cc @kinnison).

Also, do not update the translations by changing the ftl files directly in the repo: the English language is the only one supposed to change, the other ones need to be updated through Pontoon.

@Zexbe Zexbe changed the title Make install button easier Make install button easier(WIP, No Merge) Feb 5, 2020
@Zexbe Zexbe force-pushed the master branch 2 times, most recently from 82bf583 to 499559e Compare February 5, 2020 08:51
@Zexbe Zexbe changed the title Make install button easier(WIP, No Merge) Make install button easier Feb 5, 2020
@Zexbe
Copy link
Contributor Author

Zexbe commented Feb 5, 2020

Okay, ready to be reviewed

@pietroalbini
Copy link
Member

This looks way better! Thanks!

Just a last small change, could you add some margin between the buttons and the following title?

@Zexbe
Copy link
Contributor Author

Zexbe commented Feb 6, 2020

Okay

pietroalbini
pietroalbini approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's add two dots before merging.

XAMPPRocky
XAMPPRocky reviewed Feb 6, 2020
View reviewed changes
XAMPPRocky
XAMPPRocky reviewed Feb 6, 2020
View reviewed changes
@Zexbe
Copy link
Contributor Author

Zexbe commented Feb 6, 2020

Okay, updated the text

@Zexbe
Copy link
Contributor Author

Zexbe commented Feb 9, 2020

r? @XAMPPRocky

XAMPPRocky
XAMPPRocky reviewed Feb 9, 2020
View reviewed changes
XAMPPRocky
XAMPPRocky reviewed Feb 9, 2020
View reviewed changes
@seishun seishun mentioned this pull request Feb 9, 2020
Closed
@Zexbe Zexbe requested a review from XAMPPRocky February 9, 2020 21:33
@XAMPPRocky
Copy link
Member

Okay, this looks looks good to me! Thank you again for your PR!

@XAMPPRocky XAMPPRocky merged commit 4eff3cc into rust-lang:master Feb 10, 2020
XAMPPRocky added a commit to XAMPPRocky/www.rust-lang.org that referenced this pull request Feb 18, 2020
@Zexbe @XAMPPRocky
Make install button easier (rust-lang#1004)
8408eb6 
* Make install page better

* Change install detect message

* Replace nobr with span nowrap

Co-Authored-By: XAMPPRocky <[email protected]>

Co-authored-by: XAMPPRocky <[email protected]>
@upsuper upsuper mentioned this pull request Jul 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky

Assignees

@pietroalbini pietroalbini

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Zexbe @pietroalbini @XAMPPRocky