Skip to content

Was given the Unix instruction not the Windows ones. #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Y-Less opened this issue Dec 2, 2019 · 4 comments · Fixed by #1004
Closed

Was given the Unix instruction not the Windows ones. #954

Y-Less opened this issue Dec 2, 2019 · 4 comments · Fixed by #1004

Comments

@Y-Less
Copy link

Y-Less commented Dec 2, 2019

Content Bug Report

Page(s) Affected

https://www.rust-lang.org/tools/install

What needs to be fixed?

Windows download link in not on the getting started page. The website detected me as on Unix, and didn't provide any fallback option to say "no I'm not":

image

There is a "Other installation methods" link, but it is a 404. I eventually found a link to the Windows installer in the rustp repo, but it wasn't obvious.

Suggested Improvement

(optional) Do you have a suggestion for how to fix the problem? Include your ideas
here.

@steveklabnik
Copy link
Member

What OS (with version) are you on? What browser are you using?

@Y-Less
Copy link
Author

Y-Less commented Dec 2, 2019

Windows 8.1. Waterfox 56.2.4 (64-bit)

The issue was less that the website got it wrong, and more that there's no way to correct it (which also means there's no way to download for a different computer).

I also just tested on Waterfox 2019.10 and got the same thing.

@skade
Copy link
Contributor

skade commented Dec 2, 2019

Seems like Waterfox only reports itself as Win64 and we only check for Win32.

https://github.com/rust-lang/www.rust-lang.org/blob/master/static/scripts/tools-install.js#L13-L57

I'm wondering if we're even bugged on other platforms and only saved by the fallback triggering on all major browsers.

@steveklabnik
Copy link
Member

and more that there's no way to correct it (which also means there's no way to download for a different computer).

At the bottom of the page, there's a link to https://forge.rust-lang.org/infra/other-installation-methods.html, which shows you installation instructions for all platforms. Well, it should link to that, but doesn't, that's #955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants