Skip to content

N33: Add a link to a new book #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2022
Merged

N33: Add a link to a new book #1015

merged 2 commits into from
May 11, 2022

Conversation

paytonrules
Copy link
Contributor

Add a link and description to a new book about Rust gamedev.

#1010

@ozkriff ozkriff changed the title Add a link to a new book N33: Add a link to a new book May 7, 2022
ozkriff
ozkriff requested changes May 7, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice in general but a couple of style tweaks are needed

@paytonrules
Add a link to a new book
2155d33 
Add a description, follow the template and add a picture.
@paytonrules
Copy link
Contributor Author

Fixed I think

17cupsofcoffee
17cupsofcoffee approved these changes May 8, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks to the styles/wording, think it's ready to go now 👍

ozkriff
ozkriff approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

though i'd move the Discord&Twitter links to the beginning of the section as the "discussions" list is meant for specific discussions that have already happened

@AngelOnFira AngelOnFira merged commit a95a1e0 into rust-gamedev:source May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@AngelOnFira AngelOnFira AngelOnFira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paytonrules @ozkriff @17cupsofcoffee @AngelOnFira