Skip to content

Fix/assert react component with multiple case #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2019

Conversation

BookOfGreg
Copy link
Member

Summary

Extension to #961

This corrects the issue of webpacker 3 appearing to not compile when it was an execution-order dependent test. This was fixed by the WebpackerHelpers.compile_if_missing entry.

This includes extensions to test views in { name: @name, last_name: "Last #{@name}", info: { name: @name } } which completes the above linked PR.

@BookOfGreg
Copy link
Member Author

BookOfGreg commented Mar 31, 2019

The only failures are due to Travis's version of Rails 4.2 not allowing bundler 2. Will correct in #934

@BookOfGreg BookOfGreg merged commit e030634 into master Mar 31, 2019
@BookOfGreg BookOfGreg deleted the fix/assert-react-component-with-multiple-case branch March 31, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants