Skip to content

Fix assert_react_component test helper for multiple components page #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2019
Merged

Fix assert_react_component test helper for multiple components page #961

merged 1 commit into from
Mar 31, 2019

Conversation

huacnlee
Copy link
Contributor

Last commit 71ced0c have bug.

When the page have more than one React Component, assert_react_component can't catch the next items.

@BookOfGreg
Copy link
Member

Good catch! Will review this one and get Travis passing. Thanks.

@BookOfGreg BookOfGreg mentioned this pull request Mar 31, 2019
Merged
@BookOfGreg
Copy link
Member

@huacnlee I used this PR as a base for correcting some other test failures I have been experiencing.
#974

@BookOfGreg BookOfGreg merged commit 4e7d604 into reactjs:master Mar 31, 2019
@huacnlee huacnlee deleted the fix/assert-react-component-with-multiple-case branch April 1, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huacnlee @BookOfGreg