Skip to content

Drop webpacker 1 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Drop webpacker 1 #784

wants to merge 11 commits into from

Conversation

BookOfGreg
Copy link
Member

@BookOfGreg BookOfGreg commented Sep 20, 2017 •
edited
Loading

Three main changes.

  • Large deletion of tests related to Webpacker 1
  • Drop support for Webpacker 1 with changes to lib/react/server_rendering/webpacker_manifest_container.rb
  • Small refactoring to lib/react/server_rendering/webpacker_manifest_container.rb that groups code under MAJOR < 3

Edit:
This one is branched off #783 so this is mostly just c454b74

@BookOfGreg BookOfGreg mentioned this pull request Sep 20, 2017
Open
@BookOfGreg
Copy link
Member Author

I am going to close this until Webpacker 1 becomes difficult to maintain.

@BookOfGreg BookOfGreg closed this Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BookOfGreg