Drop Webpacker 1

Author: BookOfGreg

.rubocop.yml

@@ -3,7 +3,6 @@ AllCops:
   DisplayCopNames: true
   Exclude:
     - test/dummy_sprockets/**/*
-    - test/dummy_webpacker1/**/*
     - test/dummy_webpacker2/**/*
     - test/dummy_webpacker3/**/*
     - node_modules/**/*

Appraisals

@@ -48,24 +48,6 @@ appraise 'rails-4.2-sprockets_4' do
   gem 'mini_racer'
 end
 
-# no_sprockets is a magical name from sprockets_helper.rb in test to
-#   load in certain tests or not.
-appraise 'rails-5_no_sprockets_webpacker_1_1' do
-  gem 'rails', '~> 5.0.0'
-  gem 'webpacker', '~> 1.1.0'
-  # This ExecJS backend provides stateful context
-  # which the default nodejs backend does not
-  gem 'therubyracer'
-end
-
-appraise 'rails-5_no_sprockets_webpacker_1_x' do
-  gem 'rails', '~> 5.0.0'
-  gem 'webpacker', '~> 1.2'
-  # This ExecJS backend provides stateful context
-  # which the default nodejs backend does not
-  gem 'therubyracer'
-end
-
 appraise 'rails-5_no_sprockets_webpacker_2' do
   gem 'rails', '~> 5.0.0'
   gem 'webpacker', '~> 2.0'

Rakefile

@@ -94,9 +94,6 @@ task :test_setup do
   Dir.chdir('./test/dummy_sprockets') do
     `yarn install`
   end
-  Dir.chdir('./test/dummy_webpacker1') do
-    `yarn install`
-  end
   Dir.chdir('./test/dummy_webpacker2') do
     `yarn install`
   end

gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile

@@ -21,6 +21,11 @@ def self.compatible?
         !!defined?(Webpacker)
       end
 
+      def output_path
+        # Webpack1 /:output/:entry, Webpack3 /public/:output
+        config.respond_to?(:output_path) ? config.output_path : 'public'
+      end
+
       if MAJOR < 3
         def find_asset(logical_path)
           # raises if not found
@@ -37,7 +42,19 @@ def find_asset(logical_path)
             File.read(full_path)
           end
         end
-      else
+
+        def config
+          Webpacker::Configuration
+        end
+
+        def file_path path
+          manifest.lookup_path(path)
+        end
+
+        def manifest
+          Webpacker::Manifest
+        end
+      else # if MAJOR == 3
         def find_asset(logical_path)
           asset_path = Webpacker.manifest.lookup(logical_path).to_s
           if Webpacker.dev_server.running?
@@ -49,45 +66,18 @@ def find_asset(logical_path)
             File.read(file_path(logical_path))
           end
         end
-      end
-
-      if MAJOR < 3
-        def manifest
-          Webpacker::Manifest
-        end
-      else
-        def manifest
-          Webpacker.manifest
-        end
-      end
 
-      if MAJOR < 3
-        def config
-          Webpacker::Configuration
-        end
-      else
         def config
           Webpacker.config
         end
-      end
 
-      if (MAJOR == 1 && MINOR >= 2) || MAJOR == 2
-        def file_path path
-          manifest.lookup_path(path)
+        def manifest
+          Webpacker.manifest
         end
-      elsif MAJOR == 3
+
         def file_path path
           ::Rails.root.join('public', manifest.lookup(path)[1..-1])
         end
-      else # 1.0 and 1.1 support
-        def file_path path
-          File.join(output_path, manifest.lookup(path).split('/')[2..-1])
-        end
-      end
-
-      def output_path
-        # Webpack1 /:output/:entry, Webpack3 /public/:output
-        config.respond_to?(:output_path) ? config.output_path : 'public'
       end
     end
   end