Skip to content

Refactor helper lifecycle #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2015
Merged

Refactor helper lifecycle #356

merged 4 commits into from
Sep 18, 2015

Conversation

rmosolgo
Copy link
Member

Using middleware for this feature was a bad choice because, in some testing environments, middlewares aren't run.

Instead, add before_ and after_ actions to ActionController::Base to make view helpers

rmosolgo pushed a commit that referenced this pull request Sep 18, 2015
@rmosolgo rmosolgo merged commit 5aea60b into reactjs:master Sep 18, 2015
@rmosolgo rmosolgo deleted the refactor-helper-lifecycle branch September 18, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants